Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video-transcoding-scripts (separate casks) #8698

Merged
merged 4 commits into from
Jan 7, 2015
Merged

video-transcoding-scripts (separate casks) #8698

merged 4 commits into from
Jan 7, 2015

Conversation

vitorgalvao
Copy link
Member

Was waiting on depends_on :cask to land to be able to build these. Initially I had a single cask for all of them

cask :v1 => 'video-transcoding-scripts' do
  version '5.3'
  sha256 '077a789a9198f56bb7cb15017c418032f255b00a239ada71562927b9893908bb'

  url 'https://github.com/donmelton/video-transcoding-scripts/archive/master.zip'
  name 'Video Transcoding Scripts'
  homepage 'https://github.com/donmelton/video-transcoding-scripts/'
  license :mit

  binary 'video-transcoding-scripts-master/convert-video.sh', :target => 'convert-video'
  binary 'video-transcoding-scripts-master/detect-crop.sh', :target => 'detect-crop'
  binary 'video-transcoding-scripts-master/query-handbrake-log.sh', :target => 'query-handbrake-log'
  binary 'video-transcoding-scripts-master/transcode-video.sh', :target => 'transcode-video'

  depends_on :cask => 'caskroom/versions/handbrakecli-nightly',
             :formula => %w{
                            ffmpeg
                            mkvtoolnix
                            mp4v2
                            mplayer
                           }
end

but even if they live in the same repo and are complementary, they are different tools that can live on their own. It’s a different approach from what we took with batch-rip-actions-for-automator.rb, and I’d like to see how it works in practice. video-transcoding-scripts would then become an ideal case for a metacask.

@vitorgalvao vitorgalvao mentioned this pull request Jan 6, 2015
5 tasks
@rolandwalker
Copy link
Contributor

Homebrew also has soft dependencies (recommended but not required). There's no reason we can't do that as well in a future version.

@vitorgalvao
Copy link
Member Author

In a way, that’d be ideal to convert all of these into the single video-transcoding-scripts cask, but we’d need to make all of them soft dependencies, since there isn’t really a main script (well, in a way it’s transcode-video, but it’s the “main” one only in the sense it’s the one that started it all; the others don’t require it at a technical level, to work).

If there are no objections to including these four separately, I’ll merge this in in a few hours.

vitorgalvao added a commit that referenced this pull request Jan 7, 2015
video-transcoding-scripts (separate casks)
@vitorgalvao vitorgalvao merged commit 63bf46c into Homebrew:master Jan 7, 2015
@vitorgalvao vitorgalvao deleted the video-transcoding-scripts branch January 7, 2015 20:01
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants