Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl 5.36.0 grokj2k 9.7.8 rxvt-unicode 9.30 #102549

Closed
wants to merge 41 commits into from
Closed

perl 5.36.0 grokj2k 9.7.8 rxvt-unicode 9.30 #102549

wants to merge 41 commits into from

Conversation

bayandin
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels May 29, 2022
@bayandin bayandin force-pushed the bump-perl-5.36.0 branch 3 times, most recently from 1acaa57 to a5e9174 Compare May 29, 2022 21:08
@bayandin bayandin added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing CI-linux-self-hosted Build on Linux self-hosted runner and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels May 30, 2022
@chenrui333

This comment was marked as outdated.

Sign in to view
@chenrui333 chenrui333 added the linux Linux is specifically affected label May 31, 2022
@cho-m cho-m added the revision bumps needed Reverse dependencies need to have their revision incremented in the same PR label Jun 2, 2022
@cho-m
Copy link
Member

cho-m commented Jun 2, 2022

I am guessing many Linux failures are due to libperl.so linkage and will need revision bumps.

At minimum, we need revision bumps on major/minor perl updates like this PR (5.34 -> 5.36). This is based on how distros like Arch and Debian use major/minor version in library path.

In Homebrew, linked dependents will also need revision bumps on every patch/revision change since libperl.so is linked via Cellar path (see unmerged #84510 for details)

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale No recent activity label Jun 5, 2022
@danielnachun danielnachun removed the stale No recent activity label Jun 5, 2022
@bayandin bayandin added the in progress Stale bot should stay away label Jun 6, 2022
@bayandin
Copy link
Member Author

bayandin commented Jun 6, 2022

I am guessing many Linux failures are due to libperl.so linkage and will need revision bumps.

At minimum, we need revision bumps on major/minor perl updates like this PR (5.34 -> 5.36). This is based on how distros like Arch and Debian use major/minor version in library path.

In Homebrew, linked dependents will also need revision bumps on every patch/revision change since libperl.so is linked via Cellar path (see unmerged #84510 for details)

Makes sense! Will cherry-pick it

@bayandin bayandin added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 6, 2022
@bayandin bayandin force-pushed the bump-perl-5.36.0 branch from 7010186 to 361e9cf Compare June 6, 2022 11:16
@bayandin bayandin added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jun 6, 2022
@bayandin bayandin force-pushed the bump-perl-5.36.0 branch from 361e9cf to 9f68756 Compare June 6, 2022 20:17
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 7, 2022
@bayandin bayandin added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed revision bumps needed Reverse dependencies need to have their revision incremented in the same PR labels Jun 7, 2022
@bayandin bayandin force-pushed the bump-perl-5.36.0 branch 2 times, most recently from 29a36b5 to 175a25e Compare June 7, 2022 11:39
@bayandin bayandin removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 7, 2022
bayandin and others added 18 commits August 19, 2022 13:48
@bayandin
uwsgi: revision bump for perl (5.36.0)
e406c57
@bayandin
clipsafe: revision bump for perl (5.36.0)
97a380b
@bayandin
ddclient: revision bump for perl (5.36.0)
bac1063
@bayandin
extract_url: revision bump for perl (5.36.0)
e25bf18
@bayandin
feedgnuplot: revision bump for perl (5.36.0)
b7c0f06
@bayandin
get_iplayer: revision bump for perl (5.36.0)
3796e1e
@bayandin
git-svn: revision bump for perl (5.36.0)
f0c69a0
@bayandin
help2man: revision bump for perl (5.36.0)
50408b2
@bayandin
imapsync: revision bump for perl (5.36.0)
0525bf1
@bayandin
innotop: revision bump for perl (5.36.0)
96d0372
@bayandin
kpcli: revision bump for perl (5.36.0)
43c7b36
@bayandin
monkeysphere: revision bump for perl (5.36.0)
3e41144
@bayandin
mytop: revision bump for perl (5.36.0)
1d3decc
@bayandin
perl-build: revision bump for perl (5.36.0)
c80a60b
@bayandin
sql-translator: revision bump for perl (5.36.0)
eba7aef
@bayandin
sslmate: revision bump for perl (5.36.0)
f747d78
@bayandin
subversion: revision bump for perl (5.36.0)
c986043
@bayandin
po4a: revision bump for perl (5.36.0)
9138f28
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 19, 2022
@bayandin bayandin added help wanted Task(s) needing PRs from the community or maintainers and removed in progress Stale bot should stay away labels Aug 23, 2022
@carlocab
Copy link
Member

carlocab commented Sep 4, 2022

I'll have a look at this when we merge #98809, since it is pretty close and also modifies some formulae modified here.

@danielnachun
Copy link
Contributor

One thing to note - we'll want to update this to Perl 5.37 as that has since been released.

@cho-m cho-m mentioned this pull request Oct 2, 2022
Closed
6 tasks
@danielnachun
Copy link
Contributor

Superseded by #112161.

@cho-m
Copy link
Member

cho-m commented Oct 4, 2022 •
edited
Loading

grokj2k and mhonarc were only changes I didn't cherry-pick to minimize impact (others like rxvt-unicode were committed via other PRs).

  • grokj2k has been superseded by grokj2k 10.0.4 #112269
  • mhonarc is only change left. It may be worth making a separate PR for using macOS perl.

@danielnachun
Copy link
Contributor

mhonarc: #112316

@bayandin bayandin deleted the bump-perl-5.36.0 branch January 7, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. help wanted Task(s) needing PRs from the community or maintainers linux Linux is specifically affected long build Set a long timeout for formula testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bayandin @chenrui333 @cho-m @carlocab @danielnachun @BrewTestBot