Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: kubebuilder #102791

Closed
wants to merge 2 commits into from
Closed

WIP: kubebuilder #102791

wants to merge 2 commits into from

Conversation

calvinpark
Copy link

Fix the go version to 1.17, as 1.18 is not supported at this time.
Also, update the test case to follow the official doc's example.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fix the go version to 1.17, as 1.18 is not supported at this time.  
Also, update the test case to follow the official doc's example.
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Jun 2, 2022
@calvinpark calvinpark closed this Jun 11, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants