logcli loki promtail 2.6.1 #105412
Closed
logcli loki promtail 2.6.1 #105412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I've seen those are supposed to be compatible with go 1.18 (at the very least Loki), although it should still work with 1.17. |
branchvincent
force-pushed
the
logcli-loki-promtail-2.6.0
branch
from
291f903
to
3f0436b
Compare
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
branchvincent
force-pushed
the
logcli-loki-promtail-2.6.0
branch
from
3f0436b
to
e2650b9
Compare
| @@ -44,7 +43,6 @@ def install | |||
| fork { exec Formula["loki"].bin/"loki", "-config.file=loki-local-config.yaml" } | |||
| sleep 3 | |||
|
|
|||
| output = shell_output("#{bin}/logcli --addr=http://localhost:#{port} labels") | |||
| assert_match "__name__", output | |||
There was a problem hiding this comment.
__name__ was removed from this endpoint, see grafana/loki#6229
branchvincent
approved these changes
Jul 21, 2022
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?