Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy-viewer 1.4.6 #106452

Closed
wants to merge 1 commit into from
Closed

Conversation

alexhallam
Copy link
Contributor

@alexhallam alexhallam commented Jul 23, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Jul 23, 2022
@alexhallam alexhallam changed the title package update tidy-viewer-1.4.6 Jul 23, 2022
@carlocab carlocab added the checksum mismatch SHA-256 doesn't match the download label Jul 24, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the checksum doesn't match, but here's the right one.

Formula/tidy-viewer.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 27, 2022
@alexhallam
Copy link
Contributor Author

@carlocab I made the mistake of running sha on my apple binary as opposed to the tar.gz binary. It is all good now.

@carlocab carlocab changed the title tidy-viewer-1.4.6 tidy-viewer 1.4.6 Jul 27, 2022
package update

Update tidy-viewer.rb
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 27, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For future reference, our preferred commit message style for version bumps is something like

tidy-viewer 1.4.6

Additionally, please don't push merge commits to your PR branch. These it more difficult to merge your PR because of our repo's linear history requirement. (That's where the automerge-skip label came from.)

Finally, if you have a local installation of brew handy, you can automate all this with something like

brew bump-formula-pr --version=1.4.6 tidy-viewer

Or, failing that, you can use this GitHub Action to automate the creation of version bump PRs when you cut a new release.

@alexhallam
Copy link
Contributor Author

That works.

is the command brew bump-formula-pr --version=1.4.6 tidy-viewer run in by local homebrew forked directory or can I run it from anywhere?

@carlocab
Copy link
Member

You can run it anywhere. Note that bump-formula-pr will automatically create a new PR branch and push it to a fork on GitHub, so it will need access to credentials (but these can be cached).

@carlocab carlocab removed the checksum mismatch SHA-256 doesn't match the download label Jul 27, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants