Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcython: use Python's libexec/"bin" directory #107660

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Aug 9, 2022

Needed for #107517.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Aug 9, 2022
@cho-m
Copy link
Member

cho-m commented Aug 9, 2022

Not sure why error is happening on Python 3.9. I think it is related to updating setuptools resource (which may have modified bundled distutils), but it is using same version as Python 3.10.

/opt/homebrew/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
    warnings.warn(
  error: [Errno 2] No such file or directory: 'brew'

It could be trying to run a brew command but not finding command on PATH.


Also hit this on #107066 but I thought it was isolated to that PR so I just switched to stdlib distutils. Looks like there may be something else going wrong.

@cho-m
Copy link
Member

cho-m commented Aug 9, 2022

Maybe https://github.com/pypa/setuptools/blob/main/setuptools/_distutils/command/_framework_compat.py#L45 ?

    homebrew_prefix = subprocess.check_output(['brew', '--prefix'], text=True).strip()

@carlocab
Copy link
Member Author

carlocab commented Aug 9, 2022

Same conclusion at #107662.

@carlocab
Copy link
Member Author

Testing an inreplace workaround.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Aug 10, 2022
SMillerDev
SMillerDev previously approved these changes Aug 10, 2022
carlocab added a commit that referenced this pull request Aug 10, 2022
@carlocab carlocab merged commit 0af73ea into Homebrew:master Aug 10, 2022
@carlocab carlocab deleted the libcython branch August 10, 2022 23:20
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants