tbb: apply patch to fix thread creation under heavy load #108431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBB has a bug in thread creation which is exposed with usage in mold. See rui314/mold#410, rui314/mold#600. We apply a patch that has been upstreamed to TBB at oneapi-src/oneTBB#824 to fix this. The patch implements a mechanism similar to one used by Go [1], and has been adopted in the Arch and OpenSUSE TBB packages. While we're here, let's align the `cmake` invocation with other formulae, fix references to `python3.10` (Homebrew#108008), and change the `-rpath` flag so that it does not require relocation when pouring a bottle (which should speed bottle pour times up slightly). [1] https://go-review.googlesource.com/c/go/+/33894/
|
Probably not worth the re-run. |
SMillerDev
approved these changes
Aug 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBB has a bug in thread creation which is exposed with usage in mold.
See rui314/mold#410, rui314/mold#600. We apply a patch that has been
upstreamed to TBB at oneapi-src/oneTBB#824 to fix this.
The patch implements a mechanism similar to one used by Go, and has
been adopted in the Arch and OpenSUSE TBB packages.
While we're here, let's align the
cmakeinvocation with otherformulae, fix references to
python3.10(#108008), and change the-rpathflag so that it does not require relocation when pouring abottle (which should speed bottle pour times up slightly).
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?