crfsuite 0.12 (new formula) #122035
Closed
crfsuite 0.12 (new formula) #122035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebcay
force-pushed
the
crfsuite-new-formula
branch
from
f3755c3 to
1d27810
Compare
dawidd6
previously approved these changes
Feb 1, 2023
chenrui333
previously approved these changes
Feb 1, 2023
bayandin
reviewed
Feb 1, 2023
| class Crfsuite < Formula | ||
| desc "Fast implementation of conditional random fields" | ||
| homepage "https://www.chokkan.org/software/crfsuite/" | ||
| url "https://github.com/downloads/chokkan/crfsuite/crfsuite-0.12.tar.gz" |
There was a problem hiding this comment.
Wow, I didn't know there's such links like https://github.com/downloads/...
I'd suggest switching it to the format we usually use:
Suggested change
| url "https://github.com/downloads/chokkan/crfsuite/crfsuite-0.12.tar.gz" | |
| url "https://github.com/chokkan/crfsuite/archive/refs/tags/0.12.tar.gz" |
There was a problem hiding this comment.
Good catch. This is borrowing from an existing formula in the homebrew-science (legacy) tap.
There was a problem hiding this comment.
Actually, these two tarballs don't have the same contents. The original one I had includes a pre-generated configure file. The /archive tarball doesn't have it.
It seems there are other formulae in core tap that use this kind of link, e.g. apktool, jadx.
There was a problem hiding this comment.
Oh, wow, old stuff!
TIL there was a downloads API that was replaced with releases like 10 years ago.
alebcay
force-pushed
the
crfsuite-new-formula
branch
from
1d27810 to
cf5339c
Compare
alebcay
force-pushed
the
crfsuite-new-formula
branch
from
cf5339c to
faf6f8a
Compare
chenrui333
approved these changes
Feb 2, 2023
carlocab
approved these changes
Feb 2, 2023
clason
pushed a commit
to clason/homebrew-core
that referenced
this pull request
Feb 2, 2023
Closes Homebrew#122035. Signed-off-by: Rui Chen <rui@chenrui.dev> Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?