Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macvim 9.0.1677 #136237

Merged
merged 2 commits into from
Jul 10, 2023
Merged

macvim 9.0.1677 #136237

merged 2 commits into from
Jul 10, 2023

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` macos-only Formula depends on macOS labels Jul 10, 2023
@ychin
Copy link
Contributor

ychin commented Jul 10, 2023

MacVim maintainer here. I actually added a build script to MacVim in this release to automatically remove the Sparkle updater from the app after the build if it's disabled. In Homebrew's macvim.rb formula, there's this line that does the same thing:

(prefix/"MacVim.app/Contents/Frameworks/Sparkle.framework").rmtree

I don't know if this line will fail or not if Sparkle.framework doesn't exist (since it would have been removed during the build process), but either way, that line could be removed as the build process will already do it now.

See macvim-dev/macvim#1373

@ychin
Copy link
Contributor

ychin commented Jul 10, 2023

Actually, seems like the build failed with the following message:

  Error: An exception occurred within a child process:
    Errno::ENOENT: No such file or directory @ apply2files - /opt/homebrew/Cellar/macvim/9.0.1677/MacVim.app/Contents/Frameworks/Sparkle.framework

So this matches what I said. We just need to remove the line in macvim.rb that tries to remove Sparkle.framework manually and it should be all good, since it's no longer necessary.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the bump-macvim-9.0.1677 branch from 57fdb3d to 073c136 Compare July 10, 2023 14:30
@chenrui333
Copy link
Member Author

@ychin make sense, just updated the build.

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 10, 2023
@BrewTestBot BrewTestBot enabled auto-merge July 10, 2023 16:23
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 10, 2023
Merged via the queue into Homebrew:master with commit 0cf733b Jul 10, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
@chenrui333 chenrui333 deleted the bump-macvim-9.0.1677 branch January 22, 2024 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. lua Lua use is a significant feature of the PR or issue macos-only Formula depends on macOS outdated PR was locked due to age python Python use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants