-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macvim 9.0.1677 #136237
macvim 9.0.1677 #136237
Conversation
MacVim maintainer here. I actually added a build script to MacVim in this release to automatically remove the Sparkle updater from the app after the build if it's disabled. In Homebrew's macvim.rb formula, there's this line that does the same thing:
I don't know if this line will fail or not if Sparkle.framework doesn't exist (since it would have been removed during the build process), but either way, that line could be removed as the build process will already do it now. |
Actually, seems like the build failed with the following message:
So this matches what I said. We just need to remove the line in macvim.rb that tries to remove Sparkle.framework manually and it should be all good, since it's no longer necessary. |
Signed-off-by: Rui Chen <rui@chenrui.dev>
57fdb3d
to
073c136
Compare
@ychin make sense, just updated the build. |
🤖 An automated task has requested bottles to be published to this PR. |
Created with
brew bump-formula-pr
.