-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capnp: fix installation, build with fpic and build shared libraries #139577
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
The test added fails against the current build (you can see in commit c2aba45, I've squashed the commits now, but just wanted to show the error explicitly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; could you squash your commits together and use the commit message
capnp: build with fpic and shared libraries
(or similar)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; but we shouldn't switch around the method of the installation of the shared and static libraries. Shared libraries should be installed using cmake --install
.
Also, you'll need to do git fetch origin && git rebase origin/master
to pull in the changes from #139592.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work; thanks for your contribution!
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?capnproto
is only building static libraries, and these are not actually linkable. This PR adds a small test case to ensure that the libraries can be linked, and also revamps to build both static and shared libraries (based off thebamtools.rb
recipe).xref: #139476
/usr/bin/ld: /home/linuxbrew/.linuxbrew/lib/libkj.a(exception.c++.o): relocation R_X86_64_TPOFF32 against _ZN2kj12_GLOBAL__N_1L19threadLocalCallbackE' can not be used when making a shared object; recompile with -fPIC