Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lynx: use Homebrew ncurses #145170

Closed
wants to merge 3 commits into from
Closed

lynx: use Homebrew ncurses #145170

wants to merge 3 commits into from

Conversation

Rahlir
Copy link
Contributor

@Rahlir Rahlir commented Sep 23, 2023

This commit adds homebrew ncurses as dependency for lynx since macOS's
default ncurses causes screen related bugs. In particular, I encountered a bug with scrolling:

  • open a webpage
  • scroll two lines with Ctrl-N
  • the screen is not refreshed and only some text is updated, so the entire webpage gets messed up.

Using homebrew's ncurses fixes that.

This follows similar recent PRs such as #141287

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@Rahlir
lynx: use Homebrew ncurses
910dfda 
This commit adds homebrew ncurses as dependency for lynx since
macOS's default ncurses causes screen related bugs
@github-actions github-actions bot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Sep 23, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@Rahlir
lynx: make -Wno-implicit-function-declaration default for all clangs
0fcb83a 
Seems like without this option the CI fails even for clang 13.
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 23, 2023
@github-actions github-actions bot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Sep 24, 2023
@fxcoudert
Copy link
Member

License is GPL-2.0, strictly. Nowhere does it mention “or later”. See https://github.com/kurtchen/Lynx/blob/master/README and https://github.com/kurtchen/Lynx/blob/master/COPYHEADER

fxcoudert
fxcoudert previously approved these changes Sep 24, 2023
View reviewed changes
SMillerDev
SMillerDev previously approved these changes Sep 25, 2023
View reviewed changes
@github-actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed stale reviews from fxcoudert and SMillerDev September 25, 2023 00:57

Replacement PR dispatched

BrewTestBot pushed a commit that referenced this pull request Sep 25, 2023
@Rahlir @fxcoudert @BrewTestBot
lynx: revision
02b3902 
* lynx: use Homebrew ncurses
  This commit adds homebrew ncurses as dependency for lynx since
  macOS's default ncurses causes screen related bugs
* lynx: make -Wno-implicit-function-declaration default for all clangs
  Seems like without this option the CI fails even for clang 13.
* lynx: update license

Closes #145170.

Co-authored-by: FX Coudert <fxcoudert@gmail.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@BrewTestBot BrewTestBot mentioned this pull request Sep 25, 2023
Merged
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Sep 25, 2023
@BrewTestBot BrewTestBot marked this pull request as draft September 25, 2023 00:57
@github-actions
Copy link
Contributor

✅ Replacement PR created at #145676.

@p-linnane
Copy link
Member

@Rahlir Please squash your commits into one per formula in the future. Otherwise our autosquash workflow has to squash your commits and rerun CI in a new PR, which wastes time on our limited CI resources. Thank you.

github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2023
@BrewTestBot
Merge pull request #145676 from Homebrew/PR/145170
b7b30d6 
Replacement for #145170
@cho-m cho-m mentioned this pull request Jan 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@fxcoudert fxcoudert fxcoudert left review comments

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. superseded PR was replaced by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rahlir @fxcoudert @p-linnane @SMillerDev