platformio 3.4.0 #14970
platformio 3.4.0 #14970
Conversation
|
It looks like you're missing some dependencies. I recommend that you use https://github.com/tdsmith/homebrew-pypi-poet/ to fix that. |
ilovezfs
added
python
|
Thank you very much! I updated formula with poet's output. |
|
@ivankravets you're welcome. Note that the bottle block should not be altered. The test-bot handles the commits that update the bottle block automatically. |
|
I reverted back "bottle" block |
Formula/platformio.rb
Outdated
| @@ -13,31 +13,41 @@ class Platformio < Formula | |||
| sha256 "ffbfedc16ce2eccbb65ca74b48cf6c94cf24097b0fd88d70f7bc323a1435fd7f" => :yosemite | |||
| end | |||
|
|
|||
| depends_on :python if MacOS.version <= :snow_leopard | |||
There was a problem hiding this comment.
This should stay as it was.
Formula/platformio.rb
Outdated
| depends_on :python if MacOS.version <= :snow_leopard | ||
|
|
||
| depends_on :python | ||
Formula/platformio.rb
Outdated
| def install | ||
| virtualenv_install_with_resources | ||
| end | ||
|
|
||
| test do | ||
| system bin/"platformio" | ||
| system bin/"pio" | ||
| system bin/"piodebuggdb" |
There was a problem hiding this comment.
The exit code is 1 not 0, so you'll need to use shell_output("#{bin}/piodebuggdb", 1), and assert_match against some part of the output if you want to test this command.
There was a problem hiding this comment.
How we can call with piodebuggdb --help?
|
Sorry, why we should use this |
Once a formula already exists, usually |
Formula/platformio.rb
Outdated
| def install | ||
| virtualenv_install_with_resources | ||
| end | ||
|
|
||
| test do | ||
| system bin/"platformio" | ||
| system bin/"pio" | ||
| shell_output("#{bin}/platformio", 1) |
There was a problem hiding this comment.
Sorry I meant only piodebuggdb. The other two still have exit code 0.
There was a problem hiding this comment.
Strange machinery...
Formula/platformio.rb
Outdated
| system bin/"pio" | ||
| shell_output("#{bin}/platformio", 1) | ||
| shell_output("#{bin}/pio", 1) | ||
| shell_output("#{bin}/piodebuggdb", 1) |
There was a problem hiding this comment.
should use assert_match here as well
Yes that will work. |
|
Thanks! Now it looks good. |
Formula/platformio.rb
Outdated
| resource "urllib3" do | ||
| url "https://files.pythonhosted.org/packages/96/d9/40e4e515d3e17ed0adbbde1078e8518f8c4e3628496b56eb8f026a02b9e4/urllib3-1.21.1.tar.gz" | ||
| sha256 "b14486978518ca0901a76ba973d7821047409d7f726f22156b24e83fd71382a5" | ||
| end |
There was a problem hiding this comment.
There's trailing whitespace here
|
🍏 |
|
Thanks for the update @ivankravets! ❇️ |
|
Thank you too! |
Release Notes
PIO Unified Debugger
Filter PIO Unit Testing tests using a new
test_filteroption in Project Configuration File "platformio.ini" or platformio test --filter command (issue #934)Custom
test_transportfor PIO Unit Testing EngineConfigure Serial Port Monitor in Project Configuration File "platformio.ini" (issue #787)
New monitor target which allows to launch Serial Monitor automatically after successful "build" or "upload" operations (issue #788)
Project generator for VIM
Multi-line support for the different options in Project Configuration File "platformio.ini", such as:
build_flags,build_unflags, etc. (issue #889)Handle dynamic
SRC_FILTERenvironment variable from library.json extra scriptNotify about multiple installations of PIO Core (issue #961)
Improved auto-detecting of mbed-enabled media disks
Automatically update Git-submodules for development platforms and libraries that were installed from repository
Add support for
.*ccextension (issue #939)Handle
env_defaultin Project Configuration File "platformio.ini" when re-initializing a project (issue #950)Use root directory for PIO Home when path contains non-ascii characters (issue #951, issue #952)
Don't warn about known
boards_diroption (pull #949)Escape non-valid file name characters when installing a new package (library) (issue #985)
Fixed infinite dependency installing when repository consists of multiple libraries (issue #935)
Fixed linter error "unity.h does not exist" for Unit Testing (issue #947)
Fixed issue when Library Dependency Finder (LDF) does not handle custom
src_dir(issue #942)Fixed cloning a package (library) from a private Git repository with custom user name and SSH port (issue #925)