awscli: 2.15.5 #157990
Merged
awscli: 2.15.5 #157990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
autosquash
philipfischer
force-pushed
the
awscli-venv-fix
branch
from
0016e6f to
50fe517
Compare
github-actions
bot
removed
the
autosquash
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
awscli: ignore system site packages in virtualenv Configure the virtualenv created by this formula to ignore system site packages as all dependencies are installed in the virtualenv and having certain packages in the system site packages breaks awscli as described here: aws/aws-cli#7942.
bevanjkay
force-pushed
the
awscli-venv-fix
branch
from
536986c to
cb4eb51
Compare
bevanjkay
removed
the
CI-published-bottle-commits
bevanjkay
changed the title
|
Thank you @philipfischer |
bevanjkay
approved these changes
Dec 29, 2023
branchvincent
approved these changes
Dec 29, 2023
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here, awscli stops working when there is a version of pyOpenSSL >= 23.2 installed on the system. Since this formula already comes with all dependencies of awscli installed into its own virtualenv, this pr will prohibit awscli from using system site packages. This will prevent libraries installed by other tools from breaking awscli in the future.
Reproduction Steps
Install AWS CLI v2 via homebrew
Install pyOpenSSL >= 23.2. in system site packages
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?