Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ykman 5.5.1 #176069

Merged
merged 2 commits into from
Jul 2, 2024
Merged

ykman 5.5.1 #176069

merged 2 commits into from
Jul 2, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 1, 2024
@iMichka iMichka added the build failure CI fails while building the software label Jul 1, 2024
@iMichka
Copy link
Member

iMichka commented Jul 1, 2024

× Building wheel for swig (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [15 lines of output]
          /private/tmp/pip-build-env-3h83ehep/overlay/lib/python3.12/site-packages/setuptools_scm/git.py:312: UserWarning: git archive did not support describe output
            warnings.warn("git archive did not support describe output")
          /private/tmp/pip-build-env-3h83ehep/overlay/lib/python3.12/site-packages/setuptools_scm/git.py:331: UserWarning: unprocessed git archival found (no export subst applied)
            warnings.warn("unprocessed git archival found (no export subst applied)")
          Traceback (most recent call last):
            File "/private/tmp/pip-build-env-3h83ehep/overlay/lib/python3.12/site-packages/skbuild/setuptools_wrap.py", line 643, in setup
              cmkr = cmaker.CMaker(cmake_executable)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/private/tmp/pip-build-env-3h83ehep/overlay/lib/python3.12/site-packages/skbuild/cmaker.py", line 145, in __init__
              self.cmake_version = get_cmake_version(self.cmake_executable)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/private/tmp/pip-build-env-3h83ehep/overlay/lib/python3.12/site-packages/skbuild/cmaker.py", line 102, in get_cmake_version
              raise SKBuildError(msg) from err
  
          Problem with the CMake installation, aborting build. CMake executable is cmake
          [end of output]
  
      note: This error originates from a subprocess, and is likely not a problem with pip.
      ERROR: Failed building wheel for swig
    Failed to build swig
    ERROR: Could not build wheels for swig, which is required to install pyproject.toml-based projects

@chenrui333
Copy link
Member

chenrui333 commented Jul 1, 2024

@chenrui333 chenrui333 removed the build failure CI fails while building the software label Jul 1, 2024
@iMichka
Copy link
Member

iMichka commented Jul 1, 2024

I'm fine with reverting to an older psycard version for the time being. On the other hand it feels like the new versions fail to recognise our brewed swig and try to enforce pip swig

@chenrui333
Copy link
Member

On the other hand it feels like the new versions fail to recognise our brewed swig and try to enforce pip swig

yeah, that looks weird to me too, maybe raise an upstream issue about it?

@iMichka
Copy link
Member

iMichka commented Jul 1, 2024

I have added a comment here: LudovicRousseau/pyscard#169 (comment)

@cho-m
Copy link
Member

cho-m commented Jul 1, 2024

On the other hand it feels like the new versions fail to recognise our brewed swig and try to enforce pip swig

That's due to how Python build isolation works.

pyscard==2.0.10 added swig as build dependency to make sure it is available before setup.py is run (to fix the upstream user reported issue). When pip install-ed with build isolation and no PyPI wheels, this means it will build swig from PyPI sdist.

Partly a Homebrew-specific issue/limitation since we don't allow PyPI wheels and decided to not support per-PyPI-package formulae.


The workarounds we have used in other formulae include:

  • disabling build isolation. In this case, it will also require manually managing a Setuptools build-only dependency.
  • inreplacing/patching pyproject.toml to adjust dependencies. This will probably remain a permanent patch as it usually makes more sense for upstream to define all build dependencies
  • add missing dependencies to allow source-building from sdist. Not ideal, but Homebrew's approach to Python formulae is often at odds with official Python recommendations so this is sometimes the "best" among bad options.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 1, 2024
ykman: pin pyscard to 2.0.8

Signed-off-by: Rui Chen <rui@chenrui.dev>
@iMichka iMichka removed the ready to merge PR can be merged once CI is green label Jul 1, 2024
@iMichka iMichka requested a review from cho-m July 1, 2024 21:49
Copy link
Contributor

github-actions bot commented Jul 2, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 2, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit 7707c04 Jul 2, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-ykman-5.5.1 branch July 2, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants