Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubetail 0.0.2 (new formula) #194879

Merged
1 commit merged into from
Oct 21, 2024
Merged

kubetail 0.0.2 (new formula) #194879

1 commit merged into from
Oct 21, 2024

Conversation

amorey
Copy link
Contributor

@amorey amorey commented Oct 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 18, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333
Copy link
Member

checkout #91754

@chenrui333 chenrui333 changed the title Adds kubetail formula kubetail 0.8.0-rc1 (new formula) Oct 18, 2024
@amorey
Copy link
Contributor Author

amorey commented Oct 18, 2024

#91754 is for a different kubetail

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue labels Oct 18, 2024
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
@amorey
Copy link
Contributor Author

amorey commented Oct 18, 2024

@chenrui333 Thanks for the feedback! I'll work on this tomorrow.

@amorey amorey changed the title kubetail 0.8.0-rc1 (new formula) kubetail 0.0.1 (new formula) Oct 19, 2024
@amorey
Copy link
Contributor Author

amorey commented Oct 19, 2024

All the CI tests are passing except for the commit style check. Can I fix this in the PR merge message?

@daeho-ro
Copy link
Member

Squash all commits and message for commit "kubetail 0.0.1 (new formula)" then it will be passed.

Kubetail is a tool for viewing logs from multiple Kubernetes
pods simultaneously. This commit adds a new formula for the
Kubetail CLI executable (`kubetail`).

The formula has the following features:

- Builds frontend (Typescript/React) from source using pnpm and
  the backend from source using Go
- Adds shell completions from the executable
- Uses executable's built-in `serve --test` subcommand for testing
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 20, 2024
chenrui333
chenrui333 previously approved these changes Oct 20, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 20, 2024
@amorey amorey changed the title kubetail 0.0.1 (new formula) kubetail 0.0.2 (new formula) Oct 21, 2024
Copy link
Contributor

⛔ It looks like @BrewTestBot cannot push to your PR branch. Please open future pull requests from a non-organization fork to simplify the merge process.

@chenrui333
Copy link
Member

@amorey, thanks for your first contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@github-actions github-actions bot added the no push access Maintainers cannot push to this pull request. label Oct 21, 2024
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed chenrui333’s stale review October 21, 2024 17:15

Replacement PR dispatched

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Oct 21, 2024
@BrewTestBot BrewTestBot marked this pull request as draft October 21, 2024 17:16
Copy link
Contributor

✅ Replacement PR created at #195088.

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into Homebrew:master in a109d67 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core no push access Maintainers cannot push to this pull request. nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants