Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@22 22.10.0 (new formula) #195767

Merged
merged 2 commits into from
Oct 28, 2024
Merged

node@22 22.10.0 (new formula) #195767

merged 2 commits into from
Oct 28, 2024

Conversation

chenrui333
Copy link
Member

node@22 22.10.0 (new formula)


follow up #194645

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula formula deprecated Formula deprecated long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue labels Oct 27, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 27, 2024
@ianzone
Copy link

ianzone commented Oct 28, 2024

Wishing a node@lts formula 🙏

@unilynx
Copy link

unilynx commented Oct 28, 2024

Wishing a node@lts formula 🙏

That one would have jumped from node@20 to node@22. I think ideally node@22/node@23 and soon node@24 formulas would always be present instead of just 'node', as node major version updates break a lot more than eg. a postgres major update.

(even minor node version updates cause regressions often enough)

@Stanzilla
Copy link

I would like to propose that the next time a major gets bumped, the new formula for the old version gets pushed at the same time. Otherwise you end up with people stuck on something incompatible

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 28, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 28, 2024 13:56
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 191a2d6 Oct 28, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the node@22 branch October 28, 2024 14:02
@chenrui333
Copy link
Member Author

I would like to propose that the next time a major gets bumped, the new formula for the old version gets pushed at the same time. Otherwise you end up with people stuck on something incompatible

yeah, we had inconsistent practices on that, we should do it.

@chenrui333
Copy link
Member Author

Wishing a node@lts formula 🙏

there are three active node lts versions, one is current, the other two are in maintenance mode.

@stefanb stefanb mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula deprecated Formula deprecated icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants