Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h*: migrate to pkgconf (part 1) #198691

Merged
merged 16 commits into from
Nov 23, 2024
Merged

h*: migrate to pkgconf (part 1) #198691

merged 16 commits into from
Nov 23, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Nov 22, 2024
@github-actions github-actions bot added the long dependent tests Set a long timeout for dependent testing label Nov 22, 2024
Copy link
Contributor

Hi, thanks for your contribution to Homebrew! ❤️

You already have >=15 open pull requests, so please get them ready to be merged or close them before you open more. If CI fails on any of them, please fix it or ask for help doing so.

If you are performing simple version bumps, @BrewTestBot automatically bumps a list of formulae so you don't need to. Please take a look at issues and pull requests labelled help wanted Task(s) needing PRs from the community or maintainers and see if you can help to fix any of them. Thanks!

@cho-m cho-m added the long build Set a long timeout for formula testing label Nov 23, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 23, 2024
Merged via the queue into master with commit 6f47c13 Nov 23, 2024
22 checks passed
@BrewTestBot BrewTestBot deleted the pkgconf-migrations-h-1 branch November 23, 2024 11:10
@neutrinoceros
Copy link

Hi, I think this change (specifically hdf5) is causing install to fail in the following CI run
https://github.com/yt-project/yt/actions/runs/11987726777/job/33422224913
is this expected ? how should we go about it downstream ?

@daeho-ro
Copy link
Member

daeho-ro commented Nov 23, 2024

@neutrinoceros , Can you add a command to remove un-wanted pkg-config before you install the packages?

brew uninstall pkg-config@0.29.2

macos runner have changed a bit, and will be fixed on next release, would takes 1~2 weeks, I guess.

@neutrinoceros
Copy link

Thanks a lot, this seems to work !
yt-project/yt#5066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants