Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malcontent 1.7.0 (new formula) #201530

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

miketheman
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Dec 17, 2024
Formula/m/malcontent.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 17, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 17, 2024
@miketheman miketheman force-pushed the malcontent branch 3 times, most recently from 624a222 to 1a6b97c Compare December 17, 2024 19:28
Formula/m/malcontent.rb Outdated Show resolved Hide resolved
Formula/m/malcontent.rb Outdated Show resolved Hide resolved
Formula/m/malcontent.rb Outdated Show resolved Hide resolved
Formula/m/malcontent.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 17, 2024
Formula/m/malcontent.rb Outdated Show resolved Hide resolved
@egibs
Copy link
Contributor

egibs commented Dec 18, 2024

If it's easier to handle this before merging, we just cut a new release (1.7.0):

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

malcontent: update build and test

```
==> /opt/homebrew/Cellar/malcontent/1.6.0/bin/mal --version
==> /opt/homebrew/Cellar/malcontent/1.6.0/bin/mal analyze /private/tmp/malcontent-test-20241217-95084-ozeb3g
🔎 Scanning "/private/tmp/malcontent-test-20241217-95084-ozeb3g"
├─ 🟡 /private/tmp/malcontent-test-20241217-95084-ozeb3g/test.py [MEDIUM]
│     ≡ execution [MEDIUM]
│       🔵 imports/python — imports python modules: import subprocess
│       🟡 program — execute external program: subprocess.run(["echo", "execute external program"])
```

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title malcontent 1.6.0 (new formula) malcontent 1.7.0 (new formula) Dec 18, 2024
@chenrui333
Copy link
Member

@egibs totally 👍

@chenrui333
Copy link
Member

@miketheman, thanks for your contribution to Homebrew-core! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

Copy link
Contributor

⚠️ @chenrui333 bottle publish failed.

Copy link
Contributor

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 18, 2024
Merged via the queue into Homebrew:master with commit 0e96373 Dec 18, 2024
15 checks passed
@miketheman miketheman deleted the malcontent branch December 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants