Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scryer-prolog 0.9.4 (new formula) #205845

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

chriskdon
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Jan 29, 2025
@chriskdon chriskdon force-pushed the new-formula-scryer-prolog branch 3 times, most recently from c0f254d to 87ddf14 Compare January 29, 2025 04:40
@triska
Copy link

triska commented Jan 29, 2025

Thank you a lot for working on this!

In the test case, please consider writing the -g test,halt option before the file name instead of after it. Scryer-specific options should be placed before the file name (this is currently not strictly enforced, but will be enforced in the future), and only application-specific options after the file name.

@chriskdon chriskdon force-pushed the new-formula-scryer-prolog branch from 87ddf14 to 64e9dd5 Compare January 29, 2025 22:32
@chriskdon
Copy link
Contributor Author

Thanks for taking a look, @triska! I was wondering about the order of those args myself. I've made the update.

@chriskdon chriskdon marked this pull request as ready for review January 30, 2025 00:27
@chriskdon chriskdon force-pushed the new-formula-scryer-prolog branch from 64e9dd5 to 1c3c790 Compare January 30, 2025 22:57
Copy link
Contributor

github-actions bot commented Feb 5, 2025

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge February 5, 2025 15:44
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into Homebrew:master with commit e9cd767 Feb 5, 2025
15 checks passed
@chriskdon chriskdon deleted the new-formula-scryer-prolog branch February 5, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants