Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freetype 2.9 #22566

Closed
wants to merge 1 commit into from
Closed

freetype 2.9 #22566

wants to merge 1 commit into from

Conversation

lembacon
Copy link
Contributor

@lembacon lembacon commented Jan 8, 2018

Created with brew bump-formula-pr.

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

The SSL certificate for https://purl.org/net/pkgwpub/tectonic-default expired on 4 Jan, which is why the tectonic test is failing. CC @pkgw

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

Upstream issue for that is here: tectonic-typesetting/tectonic#131

@pkgw
Copy link
Contributor

pkgw commented Jan 8, 2018

Argh. I have attempted to contact archive.org multiple times about this issue — purl.org is supposed to be a bullet-proof, long-term link service, so the expired SSL cert is really disappointing. But if they can't fix it soon, I guess I'll have to update Tectonic to use another service.

@lembacon
Copy link
Contributor Author

lembacon commented Jan 8, 2018

The test for libdrawtext is failing on High Sierra, due to that the hardcoded font path /System/Library/Fonts/LastResort.ttf becomes LastResort.otf as of High Sierra.

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

@lembacon do you want to handle letting upstream know about your fix?

@lembacon
Copy link
Contributor Author

lembacon commented Jan 8, 2018

@ilovezfs For libdrawtext, there is nothing to do with upstream. The hardcoded path /System/Library/Fonts/LastResort.ttf is inside the test block of the formula.

cp "/System/Library/Fonts/LastResort.ttf", testpath
system bin/"font2glyphmap", "LastResort.ttf"

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

@pkgw I'm not sure what the best practices are for automatically keeping Let's Encrypt certificates up to date, but it seems purl.org isn't following them if this keeps happening.

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

@lembacon hehe oh ok. CAN HAZ PR? ❤️

@lembacon
Copy link
Contributor Author

lembacon commented Jan 8, 2018

@ilovezfs on it

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

thanks!

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 8, 2018

Thanks again @lembacon!

@ilovezfs ilovezfs closed this in e47b9c6 Jan 8, 2018
@lembacon lembacon deleted the freetype-2.9 branch January 9, 2018 05:11
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants