Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgui 0.7.1 #2630

Closed
wants to merge 1 commit into from
Closed

tgui 0.7.1 #2630

wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Jul 2, 2016

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the in progress Stale bot should stay away label Jul 2, 2016
@DomT4
Copy link
Member

DomT4 commented Jul 2, 2016

👍

@DomT4
Copy link
Member

DomT4 commented Jul 2, 2016

Although devel may be older than stable now? ❓

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jul 6, 2016

@DomT4 Yes, you're right. Audit didn't catch it because there's a bug in the devel spec:

iMac-TMP:Formula joe$ brew info tgui
tgui: stable 0.6.9 (bottled), devel 2

@ilovezfs ilovezfs closed this in b99fa0f Jul 6, 2016
@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Jul 6, 2016
@DomT4
Copy link
Member

DomT4 commented Jul 6, 2016

Sigh, that issue again. We'll fix that one day, hopefully.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jul 6, 2016

Yeah, I've noticed we seem to have trouble parsing devel versions from their URLs in general.

@DomT4
Copy link
Member

DomT4 commented Jul 6, 2016

Anything with an initial version and a numerical version modifier separated with a -, pretty much.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jul 6, 2016

That sounds quite fixable.

@DomT4
Copy link
Member

DomT4 commented Jul 6, 2016

It probably is. The joy is making sure that we don't involuntarily break a bunch of other versions by tweaking our core understanding of this kind of string, and nobody's really been up for that kind of testing to date.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jul 6, 2016

@DomT4 one way to check that is to dump brew info for literally everything and then just diff the before and after. It's good when all that the diff shows is ones that are currently broken that we didn't notice yet and shows nothing else.

@DomT4
Copy link
Member

DomT4 commented Jul 6, 2016

Well, if you wanted to work on it, I'm sure we could organise a cake in appreciation or something 😉.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jul 6, 2016

I may take a look. The version "123" overrides are always a heinous sight.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants