mas 1.4.2 #31058

phatblat · 2018-08-13T03:22:45Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

DomT4 · 2018-08-13T15:29:42Z

You got a lot further than I did, heh. Current failing here:

<unknown>:0: error: module map file '/tmp/mas-20180813-91738-18nl0xo/mas-1.4.2/build/Release/Commandant/Commandant.modulemap' not found
15 errors generated.
<unknown>:0: error: failed to emit precompiled header '/Users/brew/Library/Developer/Xcode/DerivedData/mas-cli-fizohytgcqxfgdbaqogeyqrzydbc/Build/Intermediates.noindex/PrecompiledHeaders/mas-cli-Bridging-Header-swift_3FGJUF6TZSKJ6-clang_3V470TLVS6FZA.pch' for bridging header '/tmp/mas-20180813-91738-18nl0xo/mas-1.4.2/App/mas-cli-Bridging-Header.h'

** BUILD FAILED **


The following build commands failed:
	CompileSwift normal x86_64
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)

phatblat · 2018-08-14T02:22:11Z

Strange, I'll investigate.

phatblat · 2018-08-15T19:34:15Z

Found the issue. Using a relative path for ~~SRCROOT~~ SYMROOT is breaking things since there are two Xcode projects at different folder levels.

It looks like buildpath should be an absolute path to where the formula is built. I tried using that as the base for ~~SRCROOT~~ SYMROOT but am still seeing the same error (I may be doing something wrong). Is there another way to get an absolute path?

DomT4 · 2018-08-15T19:49:03Z

If you can set SRCROOT try setting it to buildpath.realpath.

phatblat · 2018-08-16T02:29:07Z

Think I've got it now. Ended up using File.absolute_path(buildpath) to get it.

phatblat · 2018-08-16T02:50:59Z

Failed on sierra

20:43:55 ==> gem install bundler
20:43:55 ERROR:  Could not find a valid gem 'bundler' (>= 0), here is why:
20:43:55           Unable to download data from https://rubygems.org/ - SSL_connect returned=1 errno=0 state=SSLv2/v3 read server hello A: tlsv1 alert protocol version (https://rubygems.org/latest_specs.4.8.gz)

DomT4 · 2018-08-16T02:52:42Z

Ended up using File.absolute_path(buildpath) to get it.

Did buildpath.realpath not work in the end?

Failed on sierra

depends_on "ruby" => :build if MacOS.version <= :sierra will fix that.

DomT4 · 2018-08-16T02:53:15Z

Formula/mas.rb

@@ -14,11 +14,34 @@ class Mas < Formula
  depends_on :xcode => ["9.0", :build]

  def install
-    xcodebuild "-project", "mas-cli.xcodeproj",
+    # Pre-install a shallow copy of the CocoaPods master repo
+    system "git", "clone", "--depth", "1", "https://github.com/CocoaPods/Specs.git", File.expand_path("~/.cocoapods/repos/master")


Can we add this as a resource and then stage the resource instead of using git clone directly?

That's a good idea. 💡

phatblat · 2018-08-16T02:54:56Z

I think our custom tap may have been shadowing the core formula when I was testing buildpath.realpath. Let me try that again.

DomT4 · 2018-08-16T02:56:00Z

Formula/mas.rb

+    bash_completion.install "contrib/completion/mas-completion.bash" => "mas"
+  end
+
+  def caveats; <<~EOS


I'd rather not include these caveats, personally, as much as I appreciate that may be frustrating for y'all. We try to limit caveats pretty hard because, well, nobody really reads them and it doesn't help there are so many already 🙃.

gotcha, I'll 🔥 it

phatblat · 2018-08-16T03:07:10Z

Yeah, buildpath.realpath worked: SYMROOT=/private/tmp/mas-20180815-81376-1d0ucqx/mas-1.4.2

DomT4 · 2018-08-17T00:46:01Z

New failure on Sierra:

00:49:48 /tmp/mas-20180817-89895-wnikyq/mas-1.4.2/App/Commands/Install.swift:19:39: error: value of type '[UInt64]' has no member 'compactMap'
00:49:48         let downloadResults = options.appIds.compactMap { (appId) -> MASError? in
00:49:48                               ~~~~~~~~^~~~~~ ~~~~~~~~~~
00:49:48 /tmp/mas-20180817-89895-wnikyq/mas-1.4.2/App/Commands/Lucky.swift:38:31: error: value of type '[UInt64]' has no member 'compactMap'
00:49:48         let downloadResults = [appId].compactMap { (appId) -> MASError? in
00:49:48                               ^~~~~~~ ~~~~~~~~~~
00:49:48 /tmp/mas-20180817-89895-wnikyq/mas-1.4.2/App/Commands/Upgrade.swift:29:22: error: value of type '[String]' has no member 'compactMap'
00:49:48             appIds = apps.compactMap {
00:49:48                      ^~~~ ~~~~~~~~~~
00:49:48 /tmp/mas-20180817-89895-wnikyq/mas-1.4.2/App/Commands/Upgrade.swift:41:23: error: value of type '[UInt64]' has no member 'compactMap'
00:49:48             updates = appIds.compactMap {
00:49:48                       ^~~~~~ ~~~~~~~~~~
00:49:48 /tmp/mas-20180817-89895-wnikyq/mas-1.4.2/App/Commands/Upgrade.swift:62:29: error: value of type '[CKUpdate]' has no member 'compactMap'
00:49:48         let updateResults = updates.compactMap {
00:49:48                             ^~~~~~~ ~~~~~~~~~~
00:49:48 
00:49:48 ** BUILD FAILED **
00:49:48 
00:49:48 
00:49:48 The following build commands failed:
00:49:48 	CompileSwift normal x86_64
00:49:48 	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
00:49:48 (2 failures)
00:49:48

phatblat · 2018-08-17T02:56:34Z

Oh joy. Didn't realize that by upgrading to Swift 4.1 that it requires Xcode 9.3 and drops support for sierra.

DomT4 · 2018-08-17T03:06:15Z

Ah, yeah, that'll do it. Apple is fairly sharp on dropping support for older Xcode versions, for better or worse.

I think the discussion around system "git", "clone", "--depth", "1", "https://github.com/CocoaPods/Specs.git" is the last thing that needs doing here, assuming that CI comes back fine this time, which seems likely based off the last run.

phatblat · 2018-08-17T03:09:38Z

Yep. Just working on a script to capture a snapshot of that git repo.

DomT4 · 2018-08-17T03:18:00Z

In Homebrew terms you should be able to do something like:

resource "cocoapods" do
  url "https://github.com/CocoaPods/Specs.git",
  :revision => "ce31522ca4adfa4b4bd07dfc3bc10bbd1dd495d7"
end

def install
  (buildpath/".brew_home/.cocoapods/repos/master").install resource("cocoapods")
end

phatblat · 2018-08-17T21:19:54Z

Tried 3 approaches for this resource since I wasn't happy with the build times due to this huge git repo.

Cloning the full CocoaPods/Specs repo as per your example
- 2.3 GB
- 23m 🐌
Download a shallow clone of the repo
- 124 MB
- 7m 🐢
Download a minimal copy containing only the pods used by this project
- 22 KB
- 44s 🚗 💨

Thanks for all your help @DomT4!

DomT4 · 2018-08-18T11:53:24Z

Cloning the full CocoaPods/Specs repo as per your example

I thought resources were supposed to be shallow from GitHub (and other whitelisted links) unless explicitly requested otherwise. Am I forgetting something on this @reitermarkus?

Download a minimal copy containing only the pods used by this project

Is there a way to do this without relying on you/someone else upstream always being the one to update mas? I think the current method here pretty drastically reduces the formula's 🚌 factor, which worries me a little.

phatblat · 2018-08-18T17:25:21Z

This new complexity is the result of switching to using CocoaPods to manage dependencies in mas-cli/mas#154. I'm having second thoughts because - as you mention - it's made maintaining the formula harder. Debating using Carthage instead.

If it's any consolation, I view installing mas through Homebrew as our primary means of distribution. We have our own custom tap to support older macOS versions since the recent changes to use newer versions of Swift and Xcode have dropped support for building on all but the current version ☹️ . Also, I'm currently working on adding Homebrew building to our CI process even for PRs (mas-cli/mas#156)

phatblat · 2018-09-02T22:31:38Z

@DomT4 can we move this along?

SConaway · 2018-09-05T02:26:01Z

@phatblat @DomT4 what's going on here?

phatblat · 2018-09-05T02:34:30Z

Lots of changes to the mas formula were necessary in order to get it to build within the Homebrew environment due to the addition of CocoaPods to manage dependencies. Part of the complexity was CocoaPods downloads a huge repo. Where it stands now is a bit of a hack to prevent that download and use a slimmed-down pod repo.

I'm hoping we can move forward with this as-is and address maintenance concerns with a future update. mas-cli/mas#169 already addresses this, but I need to review it and do some testing.

SConaway · 2018-09-05T03:19:02Z

Cool. If you want any help, just let me know.

…

On Sep 4, 2018, at 7:34 PM, Ben Chatelain ***@***.***> wrote: Lots of changes to the mas formula were necessary in order to get it to build within the Homebrew environment due to the addition of CocoaPods to manage dependencies. Part of the complexity was CocoaPods downloads a huge repo. Where it stands now is a bit of a hack to prevent that download and use a slimmed-down pod repo. I'm hoping we can move forward with this as-is and address maintenance concerns with a future update. mas-cli/mas#169 already addresses this, but I need to review it and do some testing. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

fxcoudert · 2018-09-06T10:36:34Z

Formula/mas.rb

+  depends_on :xcode => ["9.3", :build]
+
+  resource "cocoapods" do
+    url "https://dl.bintray.com/phatblat/mas-bottles/master.tar.gz"


I don't think downloading an unversioned, non-official copy of the repo is acceptable in the Homebrew way of handling dependencies.

What are the alternatives? We have a cocoapods formula which we could depend on, couldn't we?

We have a cocoapods formula which we could depend on, couldn't we?

The cocoapods formula installs the command, not the repo.

Understood. I think the only option is thus to wait for mas-cli/mas#169 to be merged, which moves away from cocoapods and will allow a build compatible with Homebrew's rules.

Wasn't this suggestion #31058 (comment) using the official repo ?

fxcoudert · 2018-09-09T19:57:15Z

Formula/mas.rb

+  depends_on :xcode => ["9.3", :build]
+
+  resource "cocoapods" do
+    url "https://dl.bintray.com/phatblat/mas-bottles/master.tar.gz"


The shallow clone approach seems like the only one workable.

stale · 2018-09-30T20:50:00Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

phatblat · 2018-10-02T01:02:49Z

Closing. Will redo formula for mas 1.4.3 after mas-cli/mas#169

phatblat mentioned this pull request Aug 13, 2018

🍺 Homebrew formula update for 1.4.2 mas-cli/mas#166

Merged

DomT4 added the build failure CI fails while building the software label Aug 14, 2018

phatblat force-pushed the mas-1.4.2 branch from 1438971 to 93be111 Compare August 16, 2018 02:27

DomT4 reviewed Aug 16, 2018

View reviewed changes

phatblat force-pushed the mas-1.4.2 branch from 93be111 to 8706332 Compare August 16, 2018 23:40

phatblat force-pushed the mas-1.4.2 branch from 8706332 to d9d5166 Compare August 17, 2018 02:57

mas (1.4.2)

9db53a5

phatblat force-pushed the mas-1.4.2 branch from d9d5166 to 9db53a5 Compare August 17, 2018 20:57

DomT4 assigned fxcoudert Sep 5, 2018

fxcoudert reviewed Sep 6, 2018

View reviewed changes

javian changed the title ~~mas (1.4.2)~~ mas 1.4.2 Sep 8, 2018

fxcoudert requested changes Sep 9, 2018

View reviewed changes

stale bot added the stale No recent activity label Sep 30, 2018

phatblat closed this Oct 2, 2018

phatblat mentioned this pull request Oct 2, 2018

signin disabled on macOS 10.13+ mas-cli/mas#164

Open

ThomasKoppensteiner mentioned this pull request Oct 3, 2018

Homebrew upgrade still points to version 1.4.1 mas-cli/mas#174

Closed

jeroenj mentioned this pull request Oct 4, 2018

mas 1.4.2 #32696

Closed

4 tasks

phatblat mentioned this pull request Oct 18, 2018

mas 1.4.3 #33104

Closed

4 tasks

lembacon mentioned this pull request Oct 18, 2018

wechat-plugin 1.7.2 (new formula) #33087

Closed

4 tasks

sfdye mentioned this pull request Oct 18, 2018

Adding support for homebrew install TKkk-iOSer/WeChatPlugin-MacOS#405

Open

lock bot added the outdated PR was locked due to age label Nov 1, 2018

lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mas 1.4.2 #31058

mas 1.4.2 #31058

phatblat commented Aug 13, 2018

DomT4 commented Aug 13, 2018

phatblat commented Aug 14, 2018

phatblat commented Aug 15, 2018 •

edited

Loading

DomT4 commented Aug 15, 2018

phatblat commented Aug 16, 2018

phatblat commented Aug 16, 2018

DomT4 commented Aug 16, 2018

DomT4 Aug 16, 2018

phatblat Aug 16, 2018

phatblat commented Aug 16, 2018

DomT4 Aug 16, 2018

phatblat Aug 16, 2018

phatblat commented Aug 16, 2018

DomT4 commented Aug 17, 2018

phatblat commented Aug 17, 2018

DomT4 commented Aug 17, 2018

phatblat commented Aug 17, 2018

DomT4 commented Aug 17, 2018

phatblat commented Aug 17, 2018

DomT4 commented Aug 18, 2018 •

edited

Loading

phatblat commented Aug 18, 2018

phatblat commented Sep 2, 2018

SConaway commented Sep 5, 2018

phatblat commented Sep 5, 2018

SConaway commented Sep 5, 2018 via email

fxcoudert Sep 6, 2018 •

edited

Loading

reitermarkus Sep 6, 2018

fxcoudert Sep 6, 2018

javian Sep 8, 2018

fxcoudert Sep 9, 2018

stale bot commented Sep 30, 2018

phatblat commented Oct 2, 2018

mas 1.4.2 #31058

mas 1.4.2 #31058

Conversation

phatblat commented Aug 13, 2018

DomT4 commented Aug 13, 2018

phatblat commented Aug 14, 2018

phatblat commented Aug 15, 2018 • edited Loading

DomT4 commented Aug 15, 2018

phatblat commented Aug 16, 2018

phatblat commented Aug 16, 2018

DomT4 commented Aug 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phatblat commented Aug 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phatblat commented Aug 16, 2018

DomT4 commented Aug 17, 2018

phatblat commented Aug 17, 2018

DomT4 commented Aug 17, 2018

phatblat commented Aug 17, 2018

DomT4 commented Aug 17, 2018

phatblat commented Aug 17, 2018

DomT4 commented Aug 18, 2018 • edited Loading

phatblat commented Aug 18, 2018

phatblat commented Sep 2, 2018

SConaway commented Sep 5, 2018

phatblat commented Sep 5, 2018

SConaway commented Sep 5, 2018 via email

fxcoudert Sep 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Sep 30, 2018

phatblat commented Oct 2, 2018

phatblat commented Aug 15, 2018 •

edited

Loading

DomT4 commented Aug 18, 2018 •

edited

Loading

fxcoudert Sep 6, 2018 •

edited

Loading