Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreutils: Do not symlink dircolors, dir, and vdir #36494

Closed
wants to merge 1 commit into from

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Jan 29, 2019

Symlinking dircolors breaks Prezto.


See #36241

@ericbn
Copy link
Contributor

ericbn commented Jan 29, 2019

I am in favor of having the whole #36241 reverted. The Caveats of coreutils state that all tools are prefixed with g, and that optionally you can add all tools without prefix to the path. With #36241 this broke, and it became some or all, instead of none or all. Why can't people like @sjackman that want to use the coreutils without the prefix just add it to the path as instructed? Why?! WHY?!

Other people that have it as default (no prefixes), most likely just have it because it was installed as a dependency.

Symlinking dircolors breaks Prezto.
@sjackman
Copy link
Member Author

The Caveats of coreutils state that all tools are prefixed with g

I've addressed this discrepancy with the following change.

-    All commands have been installed with the prefix "g".
+    Commands also provided by macOS have been installed with the prefix "g".

Why can't people like @sjackman that want to use the coreutils without the prefix just add it to the path as instructed?

The specific issue that PR #36241 addressed is being able to easily install and run the common utilities md5sum, sha1sum, sha256sum, (and other *sum), shuf, tac, and truncate without additional configuration (namely adding libexec/gnubin to your PATH).

@MikeMcQuaid
Copy link
Member

Why?! WHY?!

@ericbn Please adjust your tone for future comments, please.

@ericbn
Copy link
Contributor

ericbn commented Jan 29, 2019

Sorry about my tone.

@MikeMcQuaid
Copy link
Member

Thanks @ericbn. Apology much appreciated ❤️

@lembacon lembacon closed this in 1b198c8 Jan 29, 2019
@lembacon
Copy link
Member

Thanks @sjackman!

@sjackman
Copy link
Member Author

Thanks for merging, @lembacon !

@adamchainz
Copy link

Thanks for undoing this. I was just in the middle of a dive into why my ls (aliased through prezto) was broken after upgrading all my homebrew packages, narrowed it down to dircolors and then was looking for a way to unalias it.

@lock lock bot added the outdated PR was locked due to age label Mar 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants