-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latex2html: fix executable path #39998
Conversation
sha256 "d3019ab7c34e06538dd3c24c4fae92bb212abf165144e84589bf8af9af54fdc3" => :sierra | ||
end | ||
# must build from source to configure executable path. | ||
bottle :unneeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should not hardcode a path.
"--with-texpath=#{share}/texmf/tex/latex/html" | ||
system "make", "install" | ||
end | ||
|
||
def caveats; <<~EOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, no. This is not acceptable.
latex2html depands on a TeX system (TeXLive), on macOS, it's MacTex (the only one). But it's in homebrew-cask instead of homebrew-core, we can't draw the dependence in formula. And this package is pure code, no need to bottle at the very start. Unless include mactex into brew-core, there is no way to elegantly fix it. Now latex2html is broken all the way, if it's not acceptable, please remove this formula rather then leaving a trap. |
We welcome a fix that follows the rules of homebrew formulas.
There is a
Miktex can be installed on macOS. TeXLive can be installed in non-default paths. We need to consider these possibilities. |
Confirmed by installing locally that software works fine by setting |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?fix #25024