Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latex2html: fix executable path #39998

Closed
wants to merge 1 commit into from
Closed

Conversation

holymonson
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

fix #25024

sha256 "d3019ab7c34e06538dd3c24c4fae92bb212abf165144e84589bf8af9af54fdc3" => :sierra
end
# must build from source to configure executable path.
bottle :unneeded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should not hardcode a path.

"--with-texpath=#{share}/texmf/tex/latex/html"
system "make", "install"
end

def caveats; <<~EOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, no. This is not acceptable.

@holymonson
Copy link
Contributor Author

latex2html depands on a TeX system (TeXLive), on macOS, it's MacTex (the only one). But it's in homebrew-cask instead of homebrew-core, we can't draw the dependence in formula. And this package is pure code, no need to bottle at the very start.

Unless include mactex into brew-core, there is no way to elegantly fix it. Now latex2html is broken all the way, if it's not acceptable, please remove this formula rather then leaving a trap.

@fxcoudert
Copy link
Member

Now latex2html is broken all the way

We welcome a fix that follows the rules of homebrew formulas.

this package is pure code, no need to bottle at the very start

There is a configure && make process, and the files produced are system-dependent (which we know because the bottles on different macOS versions have different checksums). So it should be bottled.

latex2html depands on a TeX system (TeXLive), on macOS, it's MacTex

Miktex can be installed on macOS. TeXLive can be installed in non-default paths. We need to consider these possibilities.

@fxcoudert
Copy link
Member

Confirmed by installing locally that software works fine by setting l2hconf.pm manually. That latex2html cannot work by autodetecting installed latex binaries when they are in PATH is their bug to fix, it's actually been reported but the project appears inactive: latex2html/latex2html#22

@fxcoudert fxcoudert closed this May 18, 2019
@lock lock bot added the outdated PR was locked due to age label Feb 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latex2html configuration is missing
2 participants