protobuf@3.1: remove #45042
protobuf@3.1: remove #45042
Conversation
|
Is there any reason besides age that this is removed? I ask because this breaks us. We are pinned to this release due to sharing protos between platforms we can't easily update our protos to be compatible with newer releases. |
|
The criteria for versioned formulas are quite strict: https://docs.brew.sh/Versions Otherwise, it seems like the best thing for you would be to maintain your own specific version in a tap: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap |
|
As FX said. Moreover, protobuf 3.1 was only included for use by another homebrew formula that couldn’t update. Now that that’s no longer the case, it got removed. See the last paragraph of the versions document. |
|
Thanks for the responses! |
| depends_on "pkg-config" => :build | ||
| depends_on "liblo" | ||
| depends_on "libmicrohttpd" | ||
| depends_on "libusb" | ||
| depends_on "numpy@1.16" | ||
| depends_on "protobuf@3.1" | ||
| depends_on "python@2" # protobuf@3.1 does not support Python 3 |
There was a problem hiding this comment.
@jonchang we still have some bugs with Python 3:
Issue: OpenLightingProject/ola#1506
WIP PR: OpenLightingProject/ola#1538
There was a problem hiding this comment.
Hopefully you will have a new release with better support soon, then :)
Ironically of course this has broken OLA's 0.10 based Mac CI! 😄 |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Remove protobuf 3.1 as it is quite old.
This also removes supersonic as it is unmaintained, and there are no installs in the last 90 days.
This also bumps a revision for
olaand migrates it toprotobuf@3.6. This currently requires a patch, see OpenLightingProject/ola#1192 from 2017. Protobuf 3.7+ support doesn't come witholayet (see OpenLightingProject/ola#1558) so we use 3.6 for now.