Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geckodriver 0.26.0 #45906

Closed
wants to merge 1 commit into from
Closed

geckodriver 0.26.0 #45906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Formula/geckodriver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
class Geckodriver < Formula
desc "WebDriver <-> Marionette proxy"
homepage "https://github.com/mozilla/geckodriver"
url "https://github.com/mozilla/geckodriver/archive/v0.25.0.tar.gz"
sha256 "9ba9b1be1a2e47ddd11216ce863903853975a4805e72b9ed5da8bcbcaebbcea9"
# Get the commit id for stable releases from https://github.com/mozilla/geckodriver/releases
url "https://hg.mozilla.org/mozilla-central/archive/e9783a644016aa9b317887076618425586730d73.tar.gz"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url returns an error

curl: (22) The requested URL returned error: 403 Archive type not allowed: gz
Error: An exception occurred within a child process:
  DownloadError: Failed to download resource "geckodriver"
Download failed: https://hg.mozilla.org/mozilla-central/archive/e9783a644016aa9b317887076618425586730d73.tar.gz

Copy link
Contributor Author

@chrmoritz chrmoritz Nov 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this. Looks like the only allowed archive type is now .zip. Working on a fix: #46746.

Copy link

@mastef mastef Nov 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np @chrmoritz was a bit frustrating after the rust dependency compiling for 2-3 hours, and then this step failing... would be also great to have just rustup being called instead of having to compile rust from source - but no idea where that's happening found it #5263

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you on an unsupported version of macOS (<= Sierra)? If not, you could also use homebrew's bottles for rust (and geckodriver) if you are considering consuming upstreams rust binaries via rustup?

version "0.26.0"
sha256 "034f525b6163ffd473ac61191107d104244b5ac7d3f89259b9c2915812654099"
head "https://hg.mozilla.org/mozilla-central/", :using => :hg

bottle do
Expand All @@ -16,8 +18,9 @@ class Geckodriver < Formula
depends_on "rust" => :build

def install
dir = build.head? ? "testing/geckodriver" : "."
cd(dir) { system "cargo", "install", "--root", prefix, "--path", "." }
cd "testing/geckodriver" do
system "cargo", "install", "--locked", "--root", prefix, "--path", "."
end
bin.install_symlink bin/"geckodriver" => "wires"
end

Expand Down