workflows: add self-hosted runners #50468
Conversation
request-info
bot
added
the
needs response
jonchang
changed the title
| brew uninstall --force --ignore-dependencies $BREW_LIST | ||
| fi | ||
| rm -rf bottles | ||
| rm -rf * |
There was a problem hiding this comment.
What's it cleaning up here? Does GitHub Actions not provide a clean space to each runner?
There was a problem hiding this comment.
I'd suggest this cleanup logic go into brew test-bot, too.
There was a problem hiding this comment.
Does GitHub Actions not provide a clean space to each runner?
For GitHub hosted runners, yes, but this is basically like Jenkins where we need to do all of that.
| run: | | ||
| mkdir bottles | ||
| cd bottles | ||
| brew test-bot --ci-pr |
There was a problem hiding this comment.
--ci-pr should be autodetected from the environment variables?
There was a problem hiding this comment.
This copies the Jenkins configuration.
There was a problem hiding this comment.
Think it could be removed there too!
| HOMEBREW_NO_ANALYTICS: 1 | ||
| HOMEBREW_NO_AUTO_UPDATE: 1 | ||
| steps: | ||
| - name: Setup tap |
There was a problem hiding this comment.
Could this use actions/checkout@master?
There was a problem hiding this comment.
This copies the Jenkins configuration. I believe test bot looks at the current brew repository, not its current directory.
There was a problem hiding this comment.
I'm not sure I understand this, can you elaborate a bit?
| BREW_LIST=$(brew list 2>/dev/null) | ||
| if [ -n "$BREW_LIST" ]; then | ||
| echo ">> brew uninstall" | ||
| brew uninstall --force --ignore-dependencies $BREW_LIST |
There was a problem hiding this comment.
brew test-bot should handle this already. If it doesn't: I suggest it's added.
There was a problem hiding this comment.
It doesn’t. I need to figure out what environment variables test bot is looking at on Jenkins to determine its cleanup behavior.
| BREW_LIST=$(brew list 2>/dev/null) | ||
| if [ -n "$BREW_LIST" ]; then | ||
| echo ">> brew uninstall" | ||
| brew uninstall --force --ignore-dependencies $BREW_LIST |
There was a problem hiding this comment.
brew test-bot should definitely handle this already.
| brew uninstall --force --ignore-dependencies $BREW_LIST | ||
| fi | ||
| rm -rf bottles | ||
| rm -rf * |
There was a problem hiding this comment.
I'd suggest this cleanup logic go into brew test-bot, too.
No description provided.