qhull 2020.1

[samford]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

This bumps the formula to the latest version (2020.1) and also adds the GitHub repo as head (it builds fine without any special modifications). [I removed the previous patch because it's incorporated into this version and no longer applicable.]

It was necessary to add ENV.cxx11 to install, since parts of qhull now require C++ 11 and the build will fail otherwise. I updated the build steps to align more with what's described in the qhull documentation while I was at it.

I've built both version 2020.1 and HEAD from source and tested both and it all looks good. Let me know if any of this could be improved or if anything needs to be changed.

[dawidd6]

==> brew audit --skip-style visp --online --git
==> FAILED
Error: 1 problem in 1 formula detected
visp:
  * Files were found with references to the Homebrew shims directory.
    The offending files are:
      lib/libvisp_core.3.3.0.dylib

[samford]

Oh dear, it looks like I'm going to have to build visp from source locally to understand what's happening there. I was really hoping to avoid it since there's such an absurd number of dependencies.

Looks like we'll also need revision bumps for octave and pcl. It's interesting that they didn't show up in the previous run.

[samford]

The bit with shims references from strings lib/libvisp_core.3.3.0.dylib is as follows:

==========================================================
General configuration information for ViSP 3.3.0
  Version control:               unknown
  Platform:
    Timestamp:                   2020-06-14T14:52:43Z
    Host:                        Darwin 19.5.0 x86_64
    CMake:                       3.17.3
    CMake generator:             Unix Makefiles
    CMake build tool:            /usr/local/Homebrew/Library/Homebrew/shims/mac/super/gmake
    Configuration:               Release
  C/C++:
    Built as dynamic libs?:      yes
    C++ Compiler:                /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  (ver 11.0.3.11030032)
    C++ flags (Release):         -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -DNDEBUG
    C++ flags (Debug):           -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -g
    C Compiler:                  /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang
    C flags (Release):           -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -DNDEBUG
    C flags (Debug):             -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -g
    Linker flags (Release):
    Linker flags (Debug):

I'm not sure how this is usually resolved in formulae, so any help would be appreciated.

[bayandin]

==========================================================
General configuration information for ViSP 3.3.0
  Version control:               unknown
  Platform:
    Timestamp:                   2020-06-14T14:52:43Z
    Host:                        Darwin 19.5.0 x86_64
    CMake:                       3.17.3
    CMake generator:             Unix Makefiles
    CMake build tool:            /usr/local/Homebrew/Library/Homebrew/shims/mac/super/gmake
    Configuration:               Release
  C/C++:
    Built as dynamic libs?:      yes
    C++ Compiler:                /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  (ver 11.0.3.11030032)
    C++ flags (Release):         -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -DNDEBUG
    C++ flags (Debug):           -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -g
    C Compiler:                  /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang
    C flags (Release):           -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -DNDEBUG
    C flags (Debug):             -Wall -Wextra -std=c++11 -fvisibility=hidden -msse2 -msse3 -mssse3 -fPIC -g
    Linker flags (Release):
    Linker flags (Debug):

It looks it's safe just to inreplace these lines in CMakeLists:

• https://github.com/lagadic/visp/blob/v3.3.0/CMakeLists.txt#L1285
• https://github.com/lagadic/visp/blob/v3.3.0/CMakeLists.txt#L1311
• https://github.com/lagadic/visp/blob/v3.3.0/CMakeLists.txt#L1314

[samford]

It looks it's safe just to inreplace these lines in CMakeLists

Is it possible to substitute information that would be appropriate (not just for macOS) instead of simply removing it?

That is to say, we could blank the information like:

    # Avoid superenv shim references
    inreplace "CMakeLists.txt" do |s|
      s.sub!(/CMake build tool:"\s+\${CMAKE_BUILD_TOOL}/, "CMake build tool:\"")
      s.sub!(/C\+\+ Compiler:"\s+\${VISP_COMPILER_STR}/, "C++ Compiler:\"")
      s.sub!(/C Compiler:"\s+\${CMAKE_C_COMPILER}/, "C Compiler:\"")
    end

but I'm not sure whether that would be the best way of dealing with this.

simgrid hardcodes /usr/bin/clang and /usr/bin/clang++ instead of CMAKE_C_COMPILER and CMAKE_CXX_COMPILER but would these always be the same, even on Linux?

[bayandin]

It looks it's safe just to inreplace these lines in CMakeLists

Is it possible to substitute information that would be appropriate (not just for macOS) instead of simply removing it?

That is to say, we could blank the information like:

    # Avoid superenv shim references
    inreplace "CMakeLists.txt" do |s|
      s.sub!(/CMake build tool:"\s+\${CMAKE_BUILD_TOOL}/, "CMake build tool:\"")
      s.sub!(/C\+\+ Compiler:"\s+\${VISP_COMPILER_STR}/, "C++ Compiler:\"")
      s.sub!(/C Compiler:"\s+\${CMAKE_C_COMPILER}/, "C Compiler:\"")
    end

but I'm not sure whether that would be the best way of dealing with this.

simgrid hardcodes /usr/bin/clang and /usr/bin/clang++ instead of CMAKE_C_COMPILER and CMAKE_CXX_COMPILER but would these always be the same, even on Linux?

Given these lines has an informational purpose only and not used anywhere, I would use the same approach as in simgrid (use relevant binaries from /usr/bin/).

[BrewTestBot]

@samford has triggered a merge.

[samford]

Thanks for the help, @bayandin!