Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re2c: disable #59094

Merged
merged 1 commit into from
Aug 4, 2020
Merged

re2c: disable #59094

merged 1 commit into from
Aug 4, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 3, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Remove the Unlicense license from re2c. It is in the public domain, not under the Unlicense license.

Disable re2c because it does not have an SPDX or OSI-approved license.

Similar to #59058.

Disable re2c because it does not have an SPDX or OSI-approved license.
@BrewTestBot BrewTestBot added the formula disabled Formula disabled label Aug 3, 2020
@jonchang jonchang merged commit 12a5f1d into Homebrew:master Aug 4, 2020
@nikic
Copy link

nikic commented Aug 4, 2020

Are there any plans to address #59058 (comment)? re2c is a build dependency of PHP and it would be convenient to have it available through Homebrew. As far as I know, all Linux distributions provide re2c, including those with strict licensing policies.

MikeMcQuaid added a commit that referenced this pull request Aug 4, 2020
php-pulls pushed a commit to php/php-src that referenced this pull request Aug 4, 2020
Avoid issues with the licensing mafia, see:
Homebrew/homebrew-core#59094

Closes GH-5932.
MikeMcQuaid added a commit that referenced this pull request Aug 4, 2020
@Rylan12 Rylan12 deleted the re2c-disable branch August 5, 2020 02:01
@Rylan12
Copy link
Member Author

Rylan12 commented Aug 5, 2020

@nikic thanks for bringing up your concern. I had a misconception about what our license requirements for Homebrew/core were. We do, actually, allow formulae that fall into the public domain (as re2c does) and re2c has been readded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formula disabled Formula disabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants