vtk: clean up problematic include paths #60380
Conversation
BrewTestBot
added
missing license
dtrodrigues
force-pushed
the
vtk-include
branch
2 times, most recently
from
b87b650 to
61458a9
Compare
BrewTestBot
removed
the
missing license
dtrodrigues
force-pushed
the
vtk-include
branch
from
61458a9 to
6f0a0b5
Compare
| @@ -79,6 +86,13 @@ def install | |||
| inreplace Dir["#{lib}/cmake/**/vtkhdf5.cmake"].first, | |||
| Formula["hdf5"].prefix.realpath, | |||
| Formula["hdf5"].opt_prefix | |||
| # get rid of bad include paths on 10.14+ | |||
There was a problem hiding this comment.
Is this issue submitted upstream?
There was a problem hiding this comment.
It's not, but it doesn't seem to be present in 9.x but I think most formulae need changes to support 9.x. I'm not positive where precisely the actual root cause is, but this will allow pcl to build which has been broken in homebrew since boost was merged in a month ago.
There was a problem hiding this comment.
Could you start an upgrade to 9.x after this then? We should always provide the latest available version of software.
There was a problem hiding this comment.
Yeah I can start the upgrade process for it after this. The cleanup after the install of vtk in this PR really isn't ideal but I think it's worth getting out so we can upgrade pcl and may be affecting other formulae using vtk.
dtrodrigues
force-pushed
the
vtk-include
branch
from
6f0a0b5 to
a4850c1
Compare
|
@Homebrew/core can somebody take a look at this as a stopgap measure? |
|
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Cleans up potentially problematic include paths, supporting #59146