Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniupnpc: conflicts_with "wownero" #60391

Closed
wants to merge 1 commit into from
Closed

miniupnpc: conflicts_with "wownero" #60391

wants to merge 1 commit into from

Conversation

claui
Copy link
Contributor

@claui claui commented Aug 30, 2020 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Add a conflicts_with directive to indicate that the newly-added wownero formula also installs a libminiupnpc.a library.

This currently blocks CI on PR #59257. To get this out of the way quickly, use conflicts_with for now instead of making miniupnpc a dependency of wownero.

@claui claui mentioned this pull request Aug 30, 2020
Closed
5 tasks
@claui
Copy link
Contributor Author

claui commented Aug 30, 2020

See also #60392.

@claui claui mentioned this pull request Aug 30, 2020
Closed
5 tasks
@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Aug 30, 2020
@claui
miniupnpc: conflicts_with "wownero"
5cdc44c 
Add a `conflicts_with` directive to indicate that the newly-added
`wownero` formula [1] also installs a `libminiupnpc.a` library.

This currently blocks CI on PR #59257 [2]. To get this out of the
way quickly, use `conflicts_with` for now instead of making
`miniupnpc` a dependency of `wownero`.

[1]: #59687

[2]: #59257
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@claui claui deleted the miniupnpc-conflict branch August 31, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
missing license Formula has a missing license which should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claui @BrewTestBot @SMillerDev