-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
envoy 1.16.0 (new formula) #61858
envoy 1.16.0 (new formula) #61858
Conversation
Build failure due to AppleClang 12 (I thought the latest version addressed this, but looks like I was testing with AppleClang 11). The project is actively working on it: envoyproxy/envoy#13364 |
@ankane Would it make sense to also include the envoy build config option |
@timsutton Do you know if/how that affects portability? |
Sadly I do not, besides it looking like this maps to c compiler optimizations. It didn't seem to change at all which frameworks were linked in, though I didn't check to see if any features changed. |
@SMillerDev Updated to the newly released 1.16.0, which fixes the tests. @timsutton I think it's better to go with the default build options (unless someone from the project can confirm the size optimizations don't affect portability). |
We generally prefer to only use default options unless there's a strong case for adding more. I'd say 300mb storage space isn't that strong a case in a time of 1TB micro-SD cards. |
👍 makes sense to me to keep the default options unless there's a very strong argument to run the size optimization. @ankane Thanks for writing this formula! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankane ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
Thanks! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?High-performance proxy