Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy 1.16.0 (new formula) #61858

Closed
wants to merge 1 commit into from
Closed

envoy 1.16.0 (new formula) #61858

wants to merge 1 commit into from

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Oct 2, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

High-performance proxy

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 2, 2020
Formula/envoy.rb Outdated Show resolved Hide resolved
@ankane
Copy link
Contributor Author

ankane commented Oct 2, 2020

Build failure due to AppleClang 12 (I thought the latest version addressed this, but looks like I was testing with AppleClang 11). The project is actively working on it: envoyproxy/envoy#13364

@timsutton
Copy link
Member

@ankane Would it make sense to also include the envoy build config option --config=sizeopt? In my testing that brought down the size of the static binary from ~400MB to ~80MB. Not sure if there might also be any other build options that would make sense for standard production usage.

@ankane
Copy link
Contributor Author

ankane commented Oct 5, 2020

@timsutton Do you know if/how that affects portability?

@timsutton
Copy link
Member

@timsutton Do you know if/how that affects portability?

Sadly I do not, besides it looking like this maps to c compiler optimizations. It didn't seem to change at all which frameworks were linked in, though I didn't check to see if any features changed.

@ankane ankane changed the title envoy 1.15.2 (new formula) envoy 1.16.0 (new formula) Oct 8, 2020
@ankane
Copy link
Contributor Author

ankane commented Oct 8, 2020

@SMillerDev Updated to the newly released 1.16.0, which fixes the tests.

@timsutton I think it's better to go with the default build options (unless someone from the project can confirm the size optimizations don't affect portability).

@SMillerDev
Copy link
Member

I think it's better to go with the default build options (unless someone from the project can confirm the size optimizations don't affect portability).

We generally prefer to only use default options unless there's a strong case for adding more. I'd say 300mb storage space isn't that strong a case in a time of 1TB micro-SD cards.

@timsutton
Copy link
Member

👍 makes sense to me to keep the default options unless there's a very strong argument to run the size optimization. @ankane Thanks for writing this formula!

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankane ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@ankane
Copy link
Contributor Author

ankane commented Oct 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants