Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebeat: migrate to python@3.9 #62795

Closed
wants to merge 1 commit into from
Closed

Conversation

fxcoudert
Copy link
Member

Splitting from #62560

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Oct 13, 2020
@fxcoudert
Copy link
Member Author

    The headers or library files could not be found for zlib,
    a required dependency when compiling Pillow from source.

There are many other Python 3.9 migration PRs that require Pillow and fail with this. I have opened an issue upstream: python-pillow/Pillow#4973

SMillerDev
SMillerDev previously approved these changes Oct 13, 2020
@SMillerDev SMillerDev dismissed their stale review October 13, 2020 13:50

Whoops, wrong PR

@@ -43,8 +45,11 @@ def install
xy = Language::Python.major_minor_version "python3"
ENV.prepend_create_path "PYTHONPATH", buildpath/"vendor/lib/python#{xy}/site-packages"

# Help Pillow find zlib
ENV.append_to_cflags "-I#{MacOS.sdk_path}/usr/include"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory at least, this should not be necessary for Pillow 8.0, thanks to python-pillow/Pillow#4974

@fxcoudert
Copy link
Member Author

Superseded by #63381

@fxcoudert fxcoudert closed this Oct 23, 2020
@fxcoudert fxcoudert deleted the filebeat branch October 23, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue python-3.9-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants