Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkages #664

Closed
wants to merge 3 commits into from
Closed

Linkages #664

wants to merge 3 commits into from

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Apr 27, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

Description

@UniqMartin
Copy link
Contributor

UniqMartin commented Apr 27, 2016

Not feeling too strongly about this, but it would be nice if the commits showed an indication what broke. I'd suggest using <formula>: revision for <dependency> like we normally do in these cases. (We normally try to synchronize these commits with version bumps to the changed dependency, but even if we aren't—like in this case—it's basically the same thing.)

@DomT4
Copy link
Member Author

DomT4 commented Apr 27, 2016

I'll try and follow that convention in future. I kind of didn't here because I've no clue in hell where the original breakage happened and typically with revision for xyz we can go "We broke this formula on this date with this commit" and trace it back. Tracing these problems back is considerably less easy.

Kind of felt like the standard revision bump message credits us with too much knowledge of cause in this situation, but I'm not fussy enough to want to stick with something different in future.

@DomT4 DomT4 closed this in 8730b56 Apr 27, 2016
@DomT4 DomT4 deleted the linkages branch April 27, 2016 20:55
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants