hdf5@1.8: update livecheck #72012
Closed
hdf5@1.8: update livecheck #72012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samford
added
livecheck
BrewTestBot
added
legacy
SMillerDev
approved these changes
Feb 26, 2021
|
🤖 A scheduled task has triggered a merge. |
|
I just noticed that the upstream source file has a different sha256: Weird |
|
I've asked upstream HDFGroup/hdf5#279 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This updates the existing
livecheckblock forhdf5@1.8to check the directory listing page where the currentstablearchive is found. The previous/ftp/HDF5/current18/src/directory only goes up to version1.8.21and doesn't include the current version used in the formula (1.8.22). The first-party download page lists1.8.22as the newest and the page for the release also links to the/ftp/HDF5/releases/hdf5-1.8/directory (used in this PR), so this seems appropriate.I also added a comment before the
stableURL to note that version1.8.23is expected to be the last release for the 1.8 series. If that version is officially acknowledged as the final release when it's published, we should consider deprecating the formula and removing thelivecheckblock at that time (so it will be automatically skipped).