Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio 5.1.1 #73346

Closed
wants to merge 2 commits into from
Closed

platformio 5.1.1 #73346

wants to merge 2 commits into from

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • Fixed a "The command line is too long" issue with a linking process on Windows (issue #3827)
  • Fixed an issue with device monitor when the "send_on_enter" filter didn't send EOL chars (issue #3787)
  • Fixed an issue with silent mode when unwanted data is printed to stdout (issue #3837)
  • Fixed an issue when code inspection fails with "Bad JSON" (issue #3790)
  • Fixed an issue with overriding user-specified debugging configuration information in VSCode (issue #3824)

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Mar 17, 2021
carlocab
carlocab reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @ivankravets. One small comment.

Formula/platformio.rb
@@ -15,14 +14,18 @@ class Platformio < Formula
sha256 cellar: :any_skip_relocation, mojave: "c2d69c80339fae7316704012f520bfe140c3141d940b87eb1524dd92e742fc63"
end

depends_on "python-tabulate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this; this is equivalent to the tabulate resource.

Formula/platformio.rb Outdated Show resolved Hide resolved
@ivankravets @carlocab
Update Formula/platformio.rb
67a1188 
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@ivankravets
Copy link
Contributor Author

Thanks! I'll open new PR/

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivankravets @carlocab @BrewTestBot