folly, fizz, wangle: build on Mojave #77819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously blocked by `folly` not building on Mojave, but no longer.
carlocab
commented
May 22, 2021
| depends_on "openssl@1.1" | ||
| depends_on "snappy" | ||
| depends_on "xz" | ||
| depends_on "zstd" | ||
|
|
||
| on_macos do | ||
| depends_on "llvm" if DevelopmentTools.clang_build_version <= 1100 |
There was a problem hiding this comment.
Tried to make this build-only, but that doesn't work.
nandahkrishna
previously approved these changes
May 22, 2021
|
Still want to check |
This was previously blocked by `folly` not building on Mojave, but no longer.
carlocab
changed the title
carlocab
commented
May 22, 2021
| def install | ||
| on_macos do | ||
| ENV.llvm_clang if DevelopmentTools.clang_build_version <= 1100 |
There was a problem hiding this comment.
Also tried building with gcc, since that's the fallback for fails_with :clang, but that doesn't work since boost is built using clang.
nandahkrishna
approved these changes
May 22, 2021
|
🤖 A scheduled task has triggered a merge. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?I haven't been able to test this since I don't have anything running Mojave, but this seems to have worked elsewhere.