Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goenv: don't inreplace init.bats on HEAD installs #88169

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

stephengroat
Copy link
Contributor

init.bats no longer exists

see go-nv/goenv#80 (comment)

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still exists in the stable tarball. Please restrict removing it to --HEAD installs only.

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Oct 28, 2021
carlocab
carlocab previously approved these changes Oct 28, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stephengroat. Cleaned this up a little for you.

@carlocab carlocab changed the title goenv: remove replace goenv: don't inreplace init.bats on HEAD installs Oct 28, 2021
@vidhanio
Copy link

Thanks for fixing this up! 😄 ❤️

@carlocab
Copy link
Member

Oops; made a mistake while fixing it up. Fixed now.

@carlocab carlocab merged commit 1543d43 into Homebrew:master Oct 28, 2021
@stephengroat stephengroat deleted the patch-2 branch October 29, 2021 16:32
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants