Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maturin: migrate to python@3.10 #88864

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Nov 5, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Nov 5, 2021
@messense
Copy link
Contributor

messense commented Nov 6, 2021

The failure is odd, we could try to change

system "python3", "-m", "pip", "install", "hello_world", "--no-index", "--find-links", testpath/"dist"

to

system "python3", "-m", "pip", "install",  testpath/"dist/hello_world*.whl"

@carlocab
Copy link
Member

carlocab commented Nov 6, 2021

The test probably fails because it's using the CLT-provided python3 in the test block. python@3.10 is keg-only, so won't be in PATH.

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Nov 20, 2021
@cclauss
Copy link
Contributor

cclauss commented Nov 23, 2021

What is the remaining TODO on this PR given that this passes all tests and maturin v0.12.0 supports Python 3.10?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to hardcode python@3.10 in multiple places that will need changing eventually.

Formula/maturin.rb Show resolved Hide resolved
Formula/maturin.rb Outdated Show resolved Hide resolved
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@carlocab carlocab merged commit c8275ea into Homebrew:master Nov 24, 2021
@Moisan Moisan deleted the maturin_python310 branch November 24, 2021 14:44
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age python-3.10-migration rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants