-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maturin: migrate to python@3.10 #88864
Conversation
Related to PyO3#646 and Homebrew/homebrew-core#88864 https://pythoninsider.blogspot.com/2021/10/python-3100-is-available.html "3.10" ___must___ be quoted in YAML. https://dev.to/hugovk/the-python-3-1-problem-85g
The failure is odd, we could try to change system "python3", "-m", "pip", "install", "hello_world", "--no-index", "--find-links", testpath/"dist" to system "python3", "-m", "pip", "install", testpath/"dist/hello_world*.whl" |
The test probably fails because it's using the CLT-provided |
e39c93c
to
0f9718b
Compare
What is the remaining TODO on this PR given that this passes all tests and maturin v0.12.0 supports Python 3.10? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to hardcode python@3.10
in multiple places that will need changing eventually.
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?