-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtorch 1.10.0 and torchvision 1.11.1 #88950
Conversation
It looks like the torchvision test failed due to pytorch/vision#4375, which requires PyTorch to download the model manually. I've updated the test to check ops are registered. |
It looks like LibTorch is ignoring the Edit: |
We could pass both. CMake will ignore unrecognised options anyway. Has the typo been reported upstream? |
Sounds good, added both for now (with a comment), and the typo is mentioned in the upstream issue. |
It looks like the failures on 11 were due to an issue with |
🤖 A scheduled task has triggered a merge. |
Thanks @carlocab and @SMillerDev |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Attempt to address #87780 and #87785
It looks like
pybind11_PREFER_third_party=OFF
was changed toUSE_SYSTEM_PYBIND11=ON
- pytorch/pytorch#58951