Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch 1.10.0 and torchvision 1.11.1 #88950

Closed
wants to merge 2 commits into from
Closed

libtorch 1.10.0 and torchvision 1.11.1 #88950

wants to merge 2 commits into from

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Nov 7, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Attempt to address #87780 and #87785

It looks like pybind11_PREFER_third_party=OFF was changed to USE_SYSTEM_PYBIND11=ON - pytorch/pytorch#58951

@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 7, 2021
@ankane
Copy link
Contributor Author

ankane commented Nov 7, 2021

It looks like the torchvision test failed due to pytorch/vision#4375, which requires PyTorch to download the model manually. I've updated the test to check ops are registered.

@ankane
Copy link
Contributor Author

ankane commented Nov 7, 2021

It looks like LibTorch is ignoring the USE_SYSTEM_PYBIND11 option. Created an issue upstream: pytorch/pytorch#67974

Edit: USE_SYSTEM_BIND11 works (but appears to be a typo), so we could use that temporarily.

@carlocab
Copy link
Member

carlocab commented Nov 8, 2021

Edit: USE_SYSTEM_BIND11 works (but appears to be a typo), so we could use that temporarily.

We could pass both. CMake will ignore unrecognised options anyway. Has the typo been reported upstream?

@ankane
Copy link
Contributor Author

ankane commented Nov 8, 2021

Sounds good, added both for now (with a comment), and the typo is mentioned in the upstream issue.

@ankane
Copy link
Contributor Author

ankane commented Nov 8, 2021

It looks like the failures on 11 were due to an issue with brew test-bot --only-setup.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@ankane
Copy link
Contributor Author

ankane commented Nov 9, 2021

Thanks @carlocab and @SMillerDev

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants