Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk v0.9.0 (new formula) #91670

Closed
wants to merge 2 commits into from
Closed

zk v0.9.0 (new formula) #91670

wants to merge 2 commits into from

Conversation

mhanberg
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Provides a formula for zk, a command-line tool helping you to maintain a plain text Zettelkasten or personal wiki.

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Dec 20, 2021
@chenrui333
Copy link
Member

  # github.com/mattn/go-sqlite3
  sqlite3-binding.c:198680:10: fatal error: 'unicode/ucol.h' file not found

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 20, 2021
@mhanberg
Copy link
Contributor Author

  # github.com/mattn/go-sqlite3
  sqlite3-binding.c:198680:10: fatal error: 'unicode/ucol.h' file not found

I think I need to compile with the homebrew version of icu4c, but the audit is telling me that i need to use the version bundled in macOS.

Any idea how to go about this?

@mhanberg
Copy link
Contributor Author

mhanberg commented Dec 20, 2021

otools is telling me the version i have working is linking to what I assume to be the macos homebrew version.

 otool -L $(which zk)
/opt/homebrew/bin/zk:
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1853.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)
        /opt/homebrew/opt/icu4c/lib/libicuuc.69.dylib (compatibility version 69.0.0, current version 69.1.0)
        /opt/homebrew/opt/icu4c/lib/libicui18n.69.dylib (compatibility version 69.0.0, current version 69.1.0)
        /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60157.30.13)

@SMillerDev
Copy link
Member

I think I need to compile with the homebrew version of icu4c, but the audit is telling me that i need to use the version bundled in macOS.

Maintainers can decide to ignore an audit if the software does not work otherwise. Just make it depend on the homebrew version.

otools is telling me the version i have working is linking to what I assume to be the macos version.

/opt/homebrew/opt/icu4c/ suggests that this is the homebrew version, not the the macOS native version.

@mhanberg
Copy link
Contributor Author

Maintainers can decide to ignore an audit if the software does not work otherwise. Just make it depend on the homebrew version.

Oh, gotcha. I'm not sure how to make the CI continue tho while failing the audit.

/opt/homebrew/opt/icu4c/ suggests that this is the homebrew version, not the the macOS native version.

That was a typo, I meant the homebrew version 😅.


I'll push it up depending on the homebrew version.

carlocab
carlocab previously approved these changes Dec 26, 2021
Formula/zk.rb Outdated Show resolved Hide resolved
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants