rust 1.61.0

[Porkepix]

Created with brew bump-formula-pr.

resource blocks may require updates.

[dtrodrigues]

Can this build with python@3.10?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[EricFromCanada]

On 12-intel:

...
     Compiling combine v4.6.3
     Compiling os_str_bytes v6.0.0
     Compiling jobserver v0.1.24
  error: could not compile `combine`
  
  Caused by:
    process didn't exit successfully: `/usr/local/Cellar/rust/1.60.0/bin/rustc --crate-name combine --edition=2018 /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/git.luolix.top-1ecc6299db9ec823/combine-4.6.3/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="alloc"' --cfg 'feature="bytes"' --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=946663382fe94ea6 -C extra-filename=-946663382fe94ea6 --out-dir /private/tmp/rust--cargo-20220412-85855-qfxu9j/target/release/deps -L dependency=/private/tmp/rust--cargo-20220412-85855-qfxu9j/target/release/deps --extern bytes=/private/tmp/rust--cargo-20220412-85855-qfxu9j/target/release/deps/libbytes-8cb23b4685950048.rmeta --extern memchr=/private/tmp/rust--cargo-20220412-85855-qfxu9j/target/release/deps/libmemchr-a49f41a35aac3a66.rmeta --cap-lints allow` (signal: 6, SIGABRT: process abort signal)
  warning: build failed, waiting for other jobs to finish...
  error: failed to compile `cargo v0.61.0 (/private/tmp/rust--cargo-20220412-85855-qfxu9j)`, intermediate artifacts can be found at `/private/tmp/rust--cargo-20220412-85855-qfxu9j/target`

[EricFromCanada]

Also on 12-Intel. Progress, I guess? (I don't seen any errors when compiling locally on 12.3.)

     Compiling openssl-sys v0.9.72
...
  error: could not compile `openssl-sys`
  
  Caused by:
    process didn't exit successfully: `/usr/local/Cellar/rust/1.60.0/bin/rustc --crate-name openssl_sys /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/git.luolix.top-1ecc6299db9ec823/openssl-sys-0.9.72/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=008c9680d21c68a1 -C extra-filename=-008c9680d21c68a1 --out-dir /private/tmp/rust--cargo-20220414-46316-k28i0w/target/release/deps -L dependency=/private/tmp/rust--cargo-20220414-46316-k28i0w/target/release/deps --extern libc=/private/tmp/rust--cargo-20220414-46316-k28i0w/target/release/deps/liblibc-fa93ba606703e75c.rmeta --cap-lints allow -L 'native=/usr/local/opt/openssl@1.1/lib' --cfg const_fn --cfg 'osslconf="OPENSSL_NO_SSL3_METHOD"' --cfg ossl101 --cfg ossl102 --cfg ossl102f --cfg ossl102h --cfg ossl110 --cfg ossl110f --cfg ossl110g --cfg ossl110h --cfg ossl111 --cfg ossl111b --cfg ossl111c -l dylib=ssl -l dylib=crypto` (signal: 6, SIGABRT: process abort signal)

[dtrodrigues]

On arm:

Warning: 2 failed steps ignored!
brew install --build-from-source rustscan
brew install --build-from-source sslyze
Error: 1 failed step!
brew install --build-from-source magic-wormhole

For rustscan, it should work once RustScan/RustScan#431 is merged.

For magic-wormhole, the build failure seems unrelated to the new version, and should be fixed by #99428 (update: merged)

For sslyze, the build failure is also unrelated to the new rust version, but a PR to fix it is #99533

[branchvincent]

May be worth comparing impact of just statically compiling upstream's jemalloc

Just pushed, I think we can try another run. Only watchman didn't get addressed

[cho-m]

Run probably hit a CI or GitHub issue given that the action looks to be in an odd state. Not sure why, but run got cancelled. Will need to re-run later, though will have to wait for another free long-timeout slot.

2022-06-16T12:20:29.9745830Z ==> brew install --build-from-source --only-dependencies aws-sso-util
2022-06-16T12:20:33.2905730Z ==> brew install --build-from-source aws-sso-util
2022-06-16T12:41:01.7964770Z ##[error]The operation was canceled.
2022-06-16T12:41:01.8111560Z ##[group]Run touch bottles/steps_output.txt

[cho-m]

11-arm64 had sporadic build failure. We can re-run by itself once everything else finishes.

12-arm64 failures seem unrelated:

• pwntools - sporadic network failure
• cjdns - looks like it is due to Monterey python removal - will separately work on fix in cjdns: fix build to find python executable #104027
• rgbds - not sure yet, but can reproduce test failure when locally building from source with rust 1.59.0. Existing bottles work. I am thinking this is due to rgbobj lacking a Cargo.lock and so the build is not reproducible.

Intel macOS runners at least haven't been randomly cancelled. 12-arm64 went down from 16h to 13h run, so some hope that it doesn't hit 3 day limit. Probably still need to wait 1 more day to get results.

[cho-m]

Pretty much all Intel macOS finished in 2d 10h with rgbds + watchman failures. Looking at last PRs for these, rgbds takes ~7m while watchman takes ~35m so should be okay on total CI time.

Only other failure is watchman which should be checked to see if unrelated. It looks like watchman built/passed on 12-arm64 so there is good chance it is something else that is causing failure on Intel.

Kicked off a re-run of 11-arm64 and should finish in half a day or so. Once CI is done and we finish looking into watchman, then PR should be good to merge.

[cho-m]

I think watchman may be failing since when we built folly/watchman we used march (e.g. nehalem) for compatibility; however, we run dependent tests with --build-from-source which doesn't seem to set any march.

folly doesn't like mixing different SSE/etc flags https://github.com/facebook/folly/blob/v2022.06.13.00/folly/container/detail/F14Table.cpp#L26-L31

// If you get a link failure that leads you here, your build has varying
// compiler flags across compilation units in a way that would break F14.
// SIMD (SSE2 or NEON) needs to be either on everywhere or off everywhere
// that uses F14.  If SIMD is on then hardware CRC needs to be enabled
// everywhere or disabled everywhere.
void F14LinkCheck<getF14IntrinsicsMode()>::check() noexcept {}

So, I think it is safe to ignore. We can triage any other issues when we bump to 2022.06.20.00.

[BrewTestBot]

@cho-m has triggered a merge.

[chenrui333]

Thanks @cho-m!!