This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
secp256k1 #42605
Closed
secp256k1 #42605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm afraid we'll need an upstream tag for this. Can you ask them for one? Thanks! |
|
I'll be surprised if upstream tags anything on this. It changes quite a bit and presumably isn't deemed hugely stable yet. I've been supporting it in a personal tap for a while with roughly weekly updates to the latest revision. |
|
Yea, I opened an issue but looks like they're not ready to commit to a stable API just yet: bitcoin-core/secp256k1#286 @DomT4 Didn't know about your tap, thanks for sharing! |
|
Ok, passing on this for now. It would be accepted in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a formula for secp256k1, a cryptographic library commonly used in bitcoin-related tools (since bitcoin uses the secp256k1 ECDSA curve).
Unfortunately the source repository does not provide version tags or anything of that sort. The library has been around for a couple of years ago and is considered stable.
It is commonly known as secp256k1 (rather than libsecp256k1) and provides a
secp256k1.hheader. There are Ruby, Python, and Node bindings that use it under this name.