This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Allow taps to link manpages. #46795
Closed
Allow taps to link manpages. #46795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +122,8 @@ def install(options = {}) | |||
| puts "Tapped #{formula_count} formula#{plural(formula_count, "e")} (#{@path.abv})" | |||
| Descriptions.cache_formulae(formula_names) | |||
|
|
|||
| link | |||
There was a problem hiding this comment.
It's better to put it before puts "Tapped....
|
@xu-cheng comments addressed. |
| (path/"man").find do |src| | ||
| next if src.directory? | ||
| dst = HOMEBREW_PREFIX/src.relative_path_from(path) | ||
| dst.delete if dst.exist? |
There was a problem hiding this comment.
We need to check the dst is a symlink pointed to this tap. Also we need to remove dir if possible.
A blocker for Homebrew/homebrew-cask#15381 being merged.
|
👍 |
|
Fixed conflicts, used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A blocker for Homebrew/homebrew-cask#15381 being merged.