-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Search also in Caskroom/versions Tap #47954
Conversation
@@ -104,7 +105,7 @@ def search_taps(rx) | |||
|
|||
def search_tap(user, repo, rx) | |||
if (HOMEBREW_LIBRARY/"Taps/#{user.downcase}/homebrew-#{repo.downcase}").directory? && \ | |||
"#{user}/#{repo}" != "Caskroom/cask" | |||
"#{user}" != "Caskroom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use user
instead of "#{user}"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in amended commit.
Extending the current search functionallity to search in https://github.com/caskroom/homebrew-versions
I think we should add this as well. With this change, homebrew is better at searching homebrew-cask than homebrew-cask itself. It’s a really sensible addition. With our stricter rules about what should go in caskroom/versions, this makes perfect sense. |
Now that versions is more cleaned up, +1 to this |
I've no objections to this personally, but will let Mike look the idea over as well as he's been the primary point of contact between Cask and Homebrew. |
CC @MikeMcQuaid on the above. |
👍, sorry for the delay. |
Thanks @tsparber! |
Extending the current search functionallity to search in
Caskroom/versions.
This repo contains many (alternate) versions of casks found in Caskroom/cask.
As an example search for
pycharm
:(In the light of Homebrew/homebrew-cask#14384)
@vitorgalvao What do you think?