Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Search also in Caskroom/versions Tap #47954

Closed
wants to merge 1 commit into from
Closed

Search also in Caskroom/versions Tap #47954

wants to merge 1 commit into from

Conversation

tsparber
Copy link
Contributor

Extending the current search functionallity to search in
Caskroom/versions.

This repo contains many (alternate) versions of casks found in Caskroom/cask.

As an example search for pycharm:

$ brew search pycharm
Caskroom/cask/pycharm-edu                       Caskroom/cask/pycharm
Caskroom/versions/pycharm-ce-eap                Caskroom/versions/pycharm-ce
Caskroom/versions/pycharm-eap 

(In the light of Homebrew/homebrew-cask#14384)

@vitorgalvao What do you think?

@@ -104,7 +105,7 @@ def search_taps(rx)

def search_tap(user, repo, rx)
if (HOMEBREW_LIBRARY/"Taps/#{user.downcase}/homebrew-#{repo.downcase}").directory? && \
"#{user}/#{repo}" != "Caskroom/cask"
"#{user}" != "Caskroom"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use user instead of "#{user}".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in amended commit.

Extending the current search functionallity to search in
https://github.com/caskroom/homebrew-versions
@vitorgalvao
Copy link
Member

@vitorgalvao What do you think?

I think we should add this as well. With this change, homebrew is better at searching homebrew-cask than homebrew-cask itself.

It’s a really sensible addition. With our stricter rules about what should go in caskroom/versions, this makes perfect sense.

@adidalal
Copy link

Now that versions is more cleaned up, +1 to this

@DomT4
Copy link
Member

DomT4 commented Jan 11, 2016

I've no objections to this personally, but will let Mike look the idea over as well as he's been the primary point of contact between Cask and Homebrew.

@DomT4
Copy link
Member

DomT4 commented Jan 14, 2016

CC @MikeMcQuaid on the above.

@MikeMcQuaid
Copy link
Member

👍, sorry for the delay.

@MikeMcQuaid
Copy link
Member

Thanks @tsparber!

@tsparber tsparber deleted the search-caskroom-versions branch January 23, 2016 05:35
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants