Kobalt 0.633 (new formula)

[cbeust]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

You can erase any parts of this template not applicable to your Pull Request.

New Formulae Submissions:

• Does your submission pass
  brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?

I'm getting:

 * Stable: version 0.633 is redundant with version scanned from URL

I tried to remove the version but then I get another error. Can you help me fix this warning?

• Have you built your formula locally prior to submission with brew install <formula>?

Changes to Homebrew's Core:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable? Here's an example if you'd like one.
• Have you successfully ran brew tests with your changes locally?

Kobalt is a build system. The test creates a simple source file and a build file and then it calls Kobalt on it. The test asserts a .jar file gets produced.

[bfontaine]

Please remove this empty line.

[cbeust]

Done.

[bfontaine]

I tried to remove the version but then I get another error. Can you help me fix this warning?

What was the other error?

[cbeust]

I didn't see the error any more after removing the version, I just pushed a new commit that address the comments.

[bfontaine]

I just saw this URL: we need to build from source.

[cbeust]

Are you saying that when someone installs Kobalt, you will build it from the source and then install the resulting binaries? (sorry if it's a silly question, I'm not very familiar with Homebrew's internals)

[MikeMcQuaid]

Yes. The exception we make is if this is Java code; it's OK for us to not build from source there because the "binaries" work cross-platform.

[cbeust]

Kobalt is written in Kotlin actually but same thing: the zip file contains a jar which is cross platform.

[MikeMcQuaid]

🆒

[cbeust]

New changes are in, please take another look. Thanks!

[MikeMcQuaid]

Use File.exist?

[cbeust]

Done.

[cbeust]

I see that brew --test verbose kobalt failed again but where can I see why?

And how come these tests pass on my machine?

[DomT4]

You passed on Jenkins. The failure was on the 10.9 Travis; the Travis machines often have connectivity problems so that may well be the root cause of failure on that:

***** WARNING Error: java.util.concurrent.ExecutionException: java.net.UnknownHostException: repo1.maven.org
***** WARNING Error: java.util.concurrent.ExecutionException: java.net.UnknownHostException: jcenter.bintray.com
*****
***** ERROR Couldn't resolve org.jetbrains.kotlin:kotlin-stdlib:1.0.0
*****
BUILD FAILED: 1
Error: kobalt: failed
Failed executing: /usr/local/Cellar/kobalt/0.633/bin/kobaltw assemble

[cbeust]

@DomT4 Got it, thanks for the explanation. Any other outstanding items I should look at?

[DomT4]

If others are okay with the binary usage, we're pretty much good IMO.

[MikeMcQuaid]

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

[cbeust]

@MikeMcQuaid and everyone else: thank you guys for the quick turnaround and making this process so seamless!