Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: pin setup-ruby action #596

Closed
wants to merge 2 commits into from
Closed

workflows: pin setup-ruby action #596

wants to merge 2 commits into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Apr 25, 2024

Pin the version of the setup-ruby action to full length commit SHA as described in the security hardening for GitHub Actions guide.

@MikeMcQuaid
Copy link
Member

Thanks @Moisan! Some failing CI here but may be able to remove that job.

woodruffw
woodruffw approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Failed job looks like a flake, re-running.)

@woodruffw
Copy link
Member

Great, now everything is flaking on CodeCov 🙃

@woodruffw
Copy link
Member

I guess we need a CodeCov token now. Fixing in another PR.

@woodruffw woodruffw added enhancement github_actions Pull requests that update Github_actions code labels Apr 25, 2024
@woodruffw
Copy link
Member

Fixed the CI failure with #597. although this is now broken because third-party (fork) PRs don't get access to secrets.CODECOV_TOKEN. I'm tempted to just remove the CodeCov integration altogether and replace it with a small workflow step that just spits out the coverage as a PR comment, since we don't treat coverage as a blocker anyways.

@woodruffw woodruffw mentioned this pull request Apr 25, 2024
Merged
auto-merge was automatically disabled April 25, 2024 18:26

Pull request was closed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
enhancement github_actions Pull requests that update Github_actions code outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @MikeMcQuaid @woodruffw