Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macho/load_commands: support LC_ATOM_INFO #612

Merged
merged 2 commits into from
May 21, 2024
Merged

macho/load_commands: support LC_ATOM_INFO #612

merged 2 commits into from
May 21, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented May 20, 2024

Fixes #609

@Bo98 Bo98 requested a review from woodruffw May 20, 2024 18:02
woodruffw
woodruffw approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It'd be nice to have a source reference for this new LC, but not required.

@woodruffw woodruffw enabled auto-merge (squash) May 21, 2024 10:00
@woodruffw woodruffw merged commit c76fc3b into master May 21, 2024
12 checks passed
@woodruffw woodruffw deleted the LC_ATOM_INFO branch May 21, 2024 10:00
@Bo98
Copy link
Member Author

Bo98 commented May 21, 2024 •
edited
Loading

In this case I used cctools: https://github.com/apple-oss-distributions/cctools/blob/7a5450708479bbff61527d5e0c32a3f7b7e4c1d0/include/mach-o/loader.h#L345.

There's also a change coming in macOS 15 that we'll want to support (but not sure if the linker can output this yet - will see): https://github.com/apple-oss-distributions/cctools/blob/7a5450708479bbff61527d5e0c32a3f7b7e4c1d0/include/mach-o/loader.h#L708-L727

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mergable Libraries are unsupported
3 participants
@Bo98 @MikeMcQuaid @woodruffw