Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to finding the page using the reference #723

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Fallback to finding the page using the reference #723

merged 2 commits into from
Jan 5, 2021

Conversation

btecu
Copy link
Contributor

@btecu btecu commented Dec 28, 2020

Fixes #722.

@Hopding
Copy link
Owner

Hopding commented Jan 2, 2021

Please see #722 (comment).

@btecu btecu changed the title [WIP] Fallback to finding the page using the reference Fallback to finding the page using the reference Jan 3, 2021
@btecu
Copy link
Contributor Author

btecu commented Jan 3, 2021

Bonus: I've added form.removeField() since it seems to be a feature other people have been asking for.

Hopding
Hopding requested changes Jan 3, 2021
View reviewed changes
Copy link
Owner

@Hopding Hopding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Thanks @btecu.

Request a few (hopefully small) changes. Then this will be ready to go 👍

src/api/PDFDocument.ts Outdated Show resolved Hide resolved
src/api/PDFDocument.ts Outdated Show resolved Hide resolved
src/api/form/PDFForm.ts Show resolved Hide resolved
src/core/PDFContext.ts Outdated Show resolved Hide resolved
src/core/PDFContext.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@btecu
Copy link
Contributor Author

btecu commented Jan 3, 2021

@Hopding feedback addressed.

@Hopding Hopding changed the base branch from master to 723-cleanup January 5, 2021 00:15
Hopding
Hopding approved these changes Jan 5, 2021
View reviewed changes
Copy link
Owner

@Hopding Hopding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated. Thanks @btecu! I'm going to update the integration tests to cover all this logic and check some new scenarios for form flattening. Then I'll merge all this to master.

@Hopding Hopding merged commit 9bf1af1 into Hopding:723-cleanup Jan 5, 2021
@Hopding Hopding mentioned this pull request Jan 5, 2021
Merged
@renovate renovate bot mentioned this pull request Jun 6, 2021
Merged
1 task
Hopding pushed a commit that referenced this pull request Aug 30, 2021
@btecu
Fallback to finding the page using the reference (#723)
414fbbf 
* Fallback to finding the page using the reference

* Handle terminal and non-terminal fields when removing a field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hopding Hopding Hopding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to flatten PDF if widget doesn't have P reference
2 participants
@btecu @Hopding