Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOM 2016-20 #442

Open
eclee25 opened this issue May 15, 2023 · 34 comments
Open

SOM 2016-20 #442

eclee25 opened this issue May 15, 2023 · 34 comments
Labels
multiyr_obs These models have multi-year observations pop_pp Large pop discrepancies between WorldPop and UNWPP means extra post-processing may be required

Comments

@eclee25
Copy link
Collaborator

eclee25 commented May 15, 2023

No description provided.

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 6, 2023

Data pull:
HASH: 6772ea9da4f43ddc3da11c494a573af2ca3dd3c8
config

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 7, 2023

Model run:
HASH: 6772ea9da4f43ddc3da11c494a573af2ca3dd3c8

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 8, 2023

country data report failed: log file

@javierps
Copy link
Collaborator

This seems to be due to the gam input object in the grid-level variance plot.
@QLLZ could you check the values that are passed to the plotting function?

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 12, 2023

@javierps Yeah, I changed the grid-level_variance plot and a new issue came up. it's about the w value: the length of w value is different in sf_grid and model.rand. After checking the log file of the model run, i found that only 1 chain successfully finished, chain 1, 3-4 actually faild.

@javierps
Copy link
Collaborator

javierps commented Jun 14, 2023

Thanks @QLLZ .

Stan model failure is possibly due to the same initialization issue in COD 2016.

@eclee25
Copy link
Collaborator Author

eclee25 commented Jun 15, 2023

Rerun on dev with drop_multiyear_adm0: yes config option

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 16, 2023

Updated config

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 17, 2023

Data pull:
HASH 02faaed1a21116cebc29533c68ec0d99fe78d08f

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 20, 2023

Model run:
HASH 02faaed1a21116cebc29533c68ec0d99fe78d08f

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 20, 2023

Country data report

@eclee25
Copy link
Collaborator Author

eclee25 commented Jun 21, 2023

Questioning whether model was run on correct branch with correct taxdat installation as there are still multi-year admin 0 obs in the stan input when these should have been dropped.

Opinion: rerun after pull / reinstallation

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 21, 2023

rerun on dev:
HASH; a4d49235ab2737ed5eaafe23264a831ab9cceef7

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 21, 2023

Model run on dev:
HASH: a4d49235ab2737ed5eaafe23264a831ab9cceef7

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 22, 2023

Similar issue as before, only 1 chain succeed.

log file

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 26, 2023

Data pull:
HASH: 23e2dc77a189bac73d6b4359bc83d99dfb99cf2f

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 26, 2023

Model run:
HASH: 23e2dc77a189bac73d6b4359bc83d99dfb99cf2f

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 26, 2023

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 28, 2023

Updated config

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 28, 2023

Data pull:
HASH: d6950c7afd2b12c35abe6d5321ddfd31a75b2cb0

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 29, 2023

Model run on dev_drop_adm0_censored
HASH: d6950c7afd2b12c35abe6d5321ddfd31a75b2cb0

@QLLZ
Copy link
Collaborator

QLLZ commented Jun 29, 2023

Mode run failed: log file

Data pull log

@eclee25
Copy link
Collaborator Author

eclee25 commented Jul 6, 2023

After drop_censored_adm0 and drop_multiyear_adm0 were turned on (with drop_censored_adm0_thresh: 1), the model was able to initialize and the outputs converged and look good.

Opinion: Exception run with drop_censored_adm0: yes and drop_censored_adm0_thresh: 1

@eclee25
Copy link
Collaborator Author

eclee25 commented Jul 17, 2023

Standard Run but with drop_censored_adm0_thresh: 1

@QLLZ
Copy link
Collaborator

QLLZ commented Jul 24, 2023

Config

Data pull & Model run:

HASH: 211913e0eb7d570ed62c48bc1ae9ecd6671a6cbc

@QLLZ
Copy link
Collaborator

QLLZ commented Jul 24, 2023

@eclee25 eclee25 added the multiyr_obs These models have multi-year observations label Jul 31, 2023
@QLLZ
Copy link
Collaborator

QLLZ commented Aug 4, 2023

Rerun on dev_u_combs_fix

HASH: e56580fa5ddab00293e31ff90139351f80ae3f6c

@QLLZ
Copy link
Collaborator

QLLZ commented Aug 7, 2023

country data report

@QLLZ
Copy link
Collaborator

QLLZ commented Aug 7, 2023

Same high incidence rate map as the other time period. Same pop estimates issue.

Modeled cases look good. Convergency looks good.

@eclee25 eclee25 added the pop_pp Large pop discrepancies between WorldPop and UNWPP means extra post-processing may be required label Aug 8, 2023
@eclee25
Copy link
Collaborator Author

eclee25 commented Aug 8, 2023

All diags look good but pop estimates are way too low. Will adjust in post processing

Approve

@eclee25
Copy link
Collaborator Author

eclee25 commented Aug 24, 2023

Standard settings with drop_censored_adm0_thresh: 1.0

@eclee25
Copy link
Collaborator Author

eclee25 commented Aug 31, 2023

With the new dummy variable censoring implementation, this model now works with the standard settings. No need to use a non-standard drop_censored_adm0_thresh parameter.

@javierps
Copy link
Collaborator

Sep 2023 Production run: all OK.

Suggestion: accept.

@eclee25
Copy link
Collaborator Author

eclee25 commented Sep 19, 2023

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiyr_obs These models have multi-year observations pop_pp Large pop discrepancies between WorldPop and UNWPP means extra post-processing may be required
Projects
None yet
Development

No branches or pull requests

3 participants